Knock::AuthTokenController extending

[nsarno]

Knock::AuthTokenController extending

[iLikeKoffee]

Added PR #48 for this issue.

[nsarno]

It should definitely be possible to achieve this by modifying the controller rather than relying on configuration. I'll have a look at merging your PR or coming with another solution whenever I can.

Thanks a lot for contributing and apologies for the late reply! 👍

[iLikeKoffee]

@nsarno No problem! Now, I achieve this customization by the entire Knock::AuthController to my project. It looks like this:

class AuthTokenController
  before_action :authenticate!

  def create
    user = find_user
    render json: {jwt: auth_token(user).token, user: user}, status: :created
  end

  # Private methods copied from Knock::AuthController.
  # This is is a workaround because those methods in Knock::AuthTokenController are private.
  # I hope this will be removed when my PR (https://github.com/nsarno/knock/pull/48) merged.

  private

  def authenticate!
    raise ActiveRecord::RecordNotFound unless user.authenticate(auth_params[:password])
  end

  def auth_token(user)
    Knock::AuthToken.new payload: {sub: user.id}
  end

  def find_user
    Knock.current_user_from_handle.call auth_params[Knock.handle_attr]
  end

  def auth_params
    params.require(:auth).permit Knock.handle_attr, :password
  end
end

It works, but It's not the most beautiful solution.
Instead, i want It look like this:

class AuthTokenController < Knock::AuthTokenController
  before_action :authenticate!

  def create
    user = find_user
    render json: {jwt: auth_token(user).token, user: user}, status: :created
  end
end

Thanks in advance!

[nsarno]

Closing this. Cf #48 and #72.