conflict of implicits with scala.concurrent.duration

[nscala-time]

conflict of implicits with scala.concurrent.duration

[kmizu]

Since it is thought that the problem cannot be avoided without changing API and conflicts of implicits are common in Scala, I recommend that either one is used without implicits. For example, the following code is right:

import com.github.nscala_time.time.RichInt
new RichInt(5).seconds

If you have a good idea to resolve this problem, I'd like to know about it.

[newffy]

Yes, I'm aware of use case without implicits, but it's not so user-friendly as the way with imlicits.
I suppose, there is only one possible way - is to define alternative API and alternative imports for those who wants to use both libs. I think because of merging akka libs to scala distrib such conflicts will be often...

[kmizu]

OK. I understood your opinion. So, What kind of API do you want? A way to avoid conflicts I can think is as the followings:

import com.github.nscala_time.time.converters.Imports._  // Alternative imports
5.toTimeUnit.seconds // Explicit invocation of toTimeUnit to avoid conflicting

I borrowed the idea from scala.collection.JavaConverters instead of scala.collection.JavaConversions.
Is the API good enough for you?

[newffy]

I think, it's good idea. At least, I don't know what can be better.)

[tototoshi]

I think it's not so good idea.

I will use joda-time directly in this case.

Like this

scala> Period.seconds(3)
res0: org.joda.time.Period = PT3S

Just because it is shorter than 3.toTimeUnit.seconds.

[kmizu]

@tototoshi Certainly.

@newffy If you don't have any other idea for this problem, I'd like to close this issue. Of course, I'll accept your pull request to solve this problem elegantly when you send it.

[webgress]

Here is what I did to solve this type of problem locally:
implicit def concurrentFiniteDurationFrom(d:com.github.nscala_time.time.DurationBuilder):scala.concurrent.duration.FiniteDuration = scala.concurrent.duration.Duration( d.millis, scala.concurrent.duration.MILLISECONDS)

My specific situation was that I needed to produce a scala.concurrent.FiniteDuration for akka unit test
as in "within(10 millis) { ..." and at the same time wanted to use this JodaTime wrapper.
That was the only reason for me to import scala.concurrent.....

I think adding my implicit function to DurationBuilder object would solve most use cases.

[rafalsobota]

@webgress nice
Can it be added to com.github.nscala_time.time.Imports?