Giter Site home page Giter Site logo

add dayOfYear method about nscala-time HOT 3 CLOSED

nscala-time avatar nscala-time commented on July 21, 2024
add dayOfYear method

from nscala-time.

Comments (3)

gakuzzzz avatar gakuzzzz commented on July 21, 2024

We can call dayOfYear and withDayOfYear method of DateTime.
The same name methods are unnecessary to define by pimp my library

from nscala-time.

tyrcho avatar tyrcho commented on July 21, 2024

cool, thanks ! the workaround is also OK using underlying.withDayOfYear until this is release.

I just added a note in the commit for a small typo in a method name.

from nscala-time.

kmizu avatar kmizu commented on July 21, 2024

Hi, @tyrcho

What @gakuzzzz said seems to be misunderstood. What he said is that dayOfYear and withDayOfYearare unnecessary to define in RichDataTime since these methods are already defined in DateTime. And It's not workaround. Then, your pull request is not merged and closed.

RichDateTime is used to add new methods to existent types, it's so-called "pimp-my-library" pattern and RichDateTime itself is not explicitly used usually. If you want to call a method defined in DateTime,
you should call the method defined in DateTime.

If I'm something wrong, let me know about it.

from nscala-time.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.