Giter Site home page Giter Site logo

Comments (3)

bradmartin avatar bradmartin commented on May 28, 2024 2

Your project shouldn't be analyzing node_modules

https://www.typescriptlang.org/docs/handbook/compiler-options.html search for -skipLibCheck. You can also look at the demo project here for how to set it in the tsconfig.

Reopen if that doesn't solve, but it should.

from nativescript-loading-indicator.

nikoTM avatar nikoTM commented on May 28, 2024

@bradmartin skipLibCheck works, but that is not the default configuration that is generated with nativescript-cli, meaning that if a user creates a new project and adds this plugin the build will fail for no obvious reasons. This solution should probably be mentioned in the readme, but ideally maybe the plugin could use View and extract native view from there, so that there is no dependency on platform declarations?

from nativescript-loading-indicator.

bradmartin avatar bradmartin commented on May 28, 2024

I'm in favor of them changing the templates, I can't see any reason why they aren't already doing that to be honest. It improves tsc performance drastically in most projects with many deps and files to process.

I also lean on the plugin being able to use the platform-declarations that NS provides, so I'll add a note to the README for now and see if they'll update their templates before making changes to the plugin.

Although your idea of grabbing the nativeView is a good idea 👍 so I'll reopen as a future improvement, but that will end up a breaking change if we remove the option, or we have to do a check for view in the common options and then the platform options which adds more code to maintain, so that's a bit discouraging for small OSS projects. Good idea though so thanks for that.

from nativescript-loading-indicator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.