Fatal error in CodeIgnitor 1.7.2

[nticompass]

Fatal error in CodeIgnitor 1.7.2

[hilyjiang]

Just comment them and it is ok now 👍

[NTICompass]

I guess I should've tested that a bit more, sorry about that. I didn't realize the 1.7.x series didn't have set_dbprefix.

[NTICompass]

It doesn't seem like there's a way to set the prefix in 1.7.x. You can get the prefix, though. The dbprefix() function still works. Odd.

Guess I'll just add a check to see if that method exists before trying to use it.

[NTICompass]

v2.4.1 checks for this function before trying to call it :-)

[hilyjiang]

Yes, it works now 👍

BTW, I think it is not a good practice to add ?> at the end of file.
It might cause BOM problem in some charset environment.

[NTICompass]

I've seen that most of CI's files don't have the ?> at the end. I just always learned to add it. Not really sure what the "conventions" is.

EDIT: It seems CodeIgniter says you should omit the ?>.
http://ellislab.com/codeigniter/user-guide/general/styleguide.html

I'll do that later, I got other work to do :-P

[hilyjiang]

For example:

a.php

<?php
    require_once('b.php');
    header('Content-Type: text/html; charset=utf-8');
?>

b.php

<?php
// nothing to do
?>

There are two blank line at the end of b.php.

Now visit a.php, the warning would come out:

Warning: Cannot modify header information - headers already sent by (output started at /var/www/b.php:5) in /var/www/a.php on line 3

Omit the close tag can solve this.

Note that if you enable output_buffering in php.ini, this problem would not appear.

[NTICompass]

I've never actually had that problem, but it seems like something that could happen. Thanks for pointing that out. 😄