Infinite "Loading market listings"

[yarushi]

Infinite "Loading market listings"

[omicron321]

yarushi lately too, but fixed it by resetting his browser.

[Nuklon]

Several questions:

• What browser are you using?
• Does it work if you change Steam's language to English?
• Does it work if you do a hard refresh (ctrl+f5)?

[yarushi]

1. Chrome
2. Not working with English
3. Not working with hard refresh too

[Nuklon]

Alright, I can't reproduce it. I've tested it on 3 different machines (Chrome + Firefox) and it's working on all of them. Maybe you can try it on another browser?

[Sparh4wk]

have exactly the same problem in chrome :( infinite loading market listings :(

UPDATE: just tryed on firefox, fresh installation, yet, same problem :(

btw its doing the same thing even if I dont have anything or market:

[Nuklon]

Does anything related to an error show up in the developer's console (F12)?
I'd like to fix it of course but as I can't reproduce it it's impossible for me.

[Sparh4wk]

Dunno if its related.. on chrome Ive got this after market refresh.

and firefox:

[Nuklon]

I don't think so, no, I have that as well and it's working fine here.
If you log network connections (Net) in Firefox, does anything show up there?
It should make connections such as:
http://steamcommunity.com/market/mylistings?count=100&start=0
http://steamcommunity.com/market/mylistings?count=100&start=100

If you manually enter that url in the browser, does that print anything that's related to your listings?

[Sparh4wk]

yes, if I enter those urls to chrome or firefox, it does print info about my listings.

[Nuklon]

Alright, so that's at least working then. I pretty much need someone with this issue that has some coding experience and can help me debug this.

[omicron321]

Hello, thanks for your great script.
I think I also had this problem... I don't know how I fixed it....
Maybe just (dis)enabling the userscript. Or messing with EnhancedSteam.

Also, the page navigation disappear : http://i.imgur.com/i3DO7HX.png

[Nuklon]

Page navigation is removed as all listings are loaded, it's pointless.

[omicron321]

The page only lists 100 items : http://i.imgur.com/onUzqTi.png
While I have 1000+ items for sale.

[omicron321]

parseInt... http://i.imgur.com/hN2CnG6.png :P

[omicron321]

Fixing it and making it display 1000+ market items is very heavy at the moment anyway...

[yarushi]

Not working with firefox too :/

[omicron321]

Here a quick-fix to apply : http://i.imgur.com/gO5V1O1.png but be aware page will be slow at beginning if you have lots of items on sale...

[yarushi]

Thanks, It's working now. But the relist button seems get removed, or is it just here ?

[Sparh4wk]

so I just found a weird thing...
if my market list is < 10 items = infinite loading
if my martket list is > 10 items = I can see list without infinite loading

hopefully this will helps you :)

[Nuklon]

Alright, I don't have 1000+ items so I couldn't test that. I already had a function to replace non numbers so I've changed that.

I have about 800 listings at market place without any performance issues (Firefox). Ideally I'd like to keep the pagination but this is problematic because the content is loaded async (every time to go to another page, even back) it's hard to show progress or any kind of feedback that's useful to the user. I think I can add some 3rd party pagination, I'll check it out later.

Regarding the listings, I'm not sure why that happens with < 10 items. Did you find any reason why?

[omicron321]

I haven't looked for < 10 items yet.

I have tested main market page. With 2000+ listed items. (thanks to your script !)
Script's performance is MUCH better on Firefox than Chrome !
And performance tools much better and useful in a first approach... (but afaik, sadly Firefox doesn't offer unminifying on the fly)

Also, I found a typo... not sure how g_bmarketwindowhidden is working, though.
injectjs unknown, because it is supposed to be injectJs http://i.imgur.com/FjgZq1v.png

[omicron321]

Oh, and those buttons appear on Firefox... but not in Chrome http://i.imgur.com/3ptBGTP.png
...but adding items to market is failing for some reasons on Firefox on my side... o_o

[Sparh4wk]

nope I didnt find anything, why < 10 items = infinite loading :(
but I can say for sure, that there is something wrong.. tryed that several times, and always same result

[Nuklon]

Firefox absolutely has a unminify option (Automatically black box minified sources).
I personally only use Firefox, never been a fan of Chrome.

For some reason the injectJs code was put to lower case, not sure when that happened but it's an easy fix (already did that).

I'll investigate the < 10 items bug too, I'll just have to remove all my 800 listings and try again, it's not that hard. I'm currently adding some pagination and a search for market listings, but I still need to style it.

[Nuklon]

Please try out 3.5.0 :)

[Sparh4wk]

niiiiiiice 👍 its working now

[Nuklon]

Including < 10 items?

[Sparh4wk]

yes, good job! 👍

[omicron321]

It works quite well.

• Actually, there must be a conflict issue with EnhancedSteam that causes performance drop (tested on Chrome).
  After disabling EnhancedSteam, market listing on main page is MUCH faster.
• sort by price : ok
• sort by name : seems ok apart for 2 items placed before the others.
• sort by date : random/unconsistant
• search item : nice feature. It doesn't search for ":" though.
• still using max price for items that have no buy offers (or recent transactions ?) o_O
• misplaced search box here : http://steamcommunity.com/market/listings/753/Snowflake%20Skin
  I get that : in that kind of item pages : http://i.imgur.com/0jI2idZ.png

[Nuklon]

I'm not using Enhanced Steam, I already made some changes regarding sorting and ES but I'm not really looking into coding a ton of extra stuff just to get around it. I accept PRs for this if anyone is feeling up to it.

Regarding the sorting: price is easy, as it's just a few numbers. sorting by name too (just using default js sort). Sort by date relies on Date.js, If there's a better library it shouldn't be too hard to use but I've yet to find one (+ localized preferably). It works rather well in English at least.

The misplaced search box, there shouldn't be on for those listings, should be fixable.

[Nuklon]

BTW, the maximum price is used for items that have no sell orders. Buy orders are only used if their price exceeds the calculated price (extremely unlikely) or if their price exceeds your maximum defined price (for example, you have the max set to 25 cents, a buy order wants to give 30 cents -> it will list it for 30 cents). This is the expected behavior and it's what I want, it doesn't make sense from an economic point of view to take your minimum price for example.

[omicron321]

I am talking about that kind of cases : http://i.imgur.com/jOSskWG.png
No buying offers => the autosell will use max price. At least, that is what I get like 99% of cases.
Though, it doesn't matter for me anymore. Everything from my inventory went on sale. And I (or anyone) can force very low max price if needed.

About ES :
As ES is quite use, some people might want to be aware of temporary fix when they want to use Steam-Economy-Enhancer.
As ES is injecting scripts a bit everywhere on Steam, it should ES responsibility to offer more options to disable what it does on market page.

[Nuklon]

Can you also send me one of these cards that's 100% certain causing issues? This should also be fixed then 👍

[Nuklon]

Fixed the search box, the rest seems to fixed in here.

[Botan626]

Hello. Just installed this extension, and I'm having this issue.

[Sparh4wk]

yes, the issue < 10 = infinite loading is back :(

[Nuklon]

I'll investigate this again.

[Nuklon]

I think I found the problem and have fixed it, will upload a new version in a sec.