Giter Site home page Giter Site logo

Comments (3)

wookayin avatar wookayin commented on June 20, 2024

Thanks for your follow-up. For the first two items, I agree with you. Initially I tried with calling like nvm.async_call(fn, arg1, arg2, kwarg=1) but it was a bit confusing to me. Generally speaking the wrapper style seems more intuitive to me as it looks more like calling a callable (function).

For the latter two items, I'm not quite sure. But I would be happy to help with following them up.

from semshi.

numirias avatar numirias commented on June 20, 2024

Wrapping the callable makes a lot of sense, but I think I'd prefer lambda expressions because that spares us the extra wrapper function while keeping the code easy to read. E.g. instead of

self._wrap_async(self._buf.clear_highlight)(ERROR_HL_ID)

you'd do

self._vim.async_call(lambda: self._buf.clear_highlight(ERROR_HL_ID))

But either way, it's not a pressing issue.

from semshi.

wookayin avatar wookayin commented on June 20, 2024

I also like the lambda-style way of calling, as it looks more concise. I would be happy with you cleaning up the codes in such a way.

from semshi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.