git branch cleanup returns errors.

[TeaDrinkingProgrammer]

git branch cleanup returns errors.

[fdncred]

I suspect this is because of 2 reasons

1. --redirect-stdout and --redirect-stderr have been deprecated
2. all the rest arguments to custom commands need to use the spread operator, not in just one custom command.

[AucaCoyan]

I suspect this was fixed in #799 , is that correct @TeaDrinkingProgrammer ?

[TeaDrinkingProgrammer]

Some errors have been resolved, but --redirect-stdout is still used, so I get depricated warnings for that and the script also doesn't seem to work anymore:

Error: × Deprecated flag
╭─[C:\Users\Stijn\AppData\Roaming\nushell\scripts\git_branch_cleanup.nu:59:16]
58 │ def current_branch [] {
59 │ run-external --redirect-stdout "git" "branch" "--show-current"
· ────────────────────────┬────────────────────────
· ╰── --redirect-stdout is deprecated
60 │ | into string
╰────
help: run-external will now always redirect stdout if there is a pipe | afterwards

Error: × Deprecated flag
╭─[C:\Users\Stijn\AppData\Roaming\nushell\scripts\git_branch_cleanup.nu:88:16]
87 │
88 │ run-external --redirect-stdout "git" "symbolic-ref" $args
· ──────────────────────┬─────────────────────
· ╰── --redirect-stdout is deprecated
89 │ | str trim
╰────
help: run-external will now always redirect stdout if there is a pipe | afterwards

Error: nu::shell::cannot_pass_list_to_external

× Lists are not automatically spread when calling external commands
╭─[C:\Users\Stijn\AppData\Roaming\nushell\scripts\git_branch_cleanup.nu:88:55]
87 │
88 │ run-external --redirect-stdout "git" "symbolic-ref" $args
· ──┬──
· ╰── Spread operator (...) is necessary to spread lists
89 │ | str trim
╰────
help: Either convert the list to a string or use the spread operator, like so: ...$args

[AucaCoyan]

The deprecation warning is because the CI is using latest nushell version 0.92, released Apr-02,
here is a link to the deprecated commands chapter in the blogpost