'url join' ignores username when password is null

[richardwesthaver]

'url join' ignores username when password is null

[richardwesthaver]

likely culprit:

nushell/crates/nu-command/src/network/url/join.rs

Lines 319 to 357 in 175dab4

	pub fn to_url(&self, span: Span) -> Result<String, ShellError> {
	let mut user_and_pwd: String = String::from("");
	if let Some(usr) = &self.username {
	if let Some(pwd) = &self.password {
	user_and_pwd = format!("{usr}:{pwd}@");
	}
	}
	let scheme_result = match &self.scheme {
	Some(s) => Ok(s),
	None => Err(UrlComponents::generate_shell_error_for_missing_parameter(
	String::from("scheme"),
	span,
	)),
	};
	let host_result = match &self.host {
	Some(h) => Ok(h),
	None => Err(UrlComponents::generate_shell_error_for_missing_parameter(
	String::from("host"),
	span,
	)),
	};
	Ok(format!(
	"{}://{}{}{}{}{}{}",
	scheme_result?,
	user_and_pwd,
	host_result?,
	self.port
	.map(|p| format!(":{p}"))
	.as_deref()
	.unwrap_or_default(),
	self.path.as_deref().unwrap_or_default(),
	self.query.as_deref().unwrap_or_default(),
	self.fragment.as_deref().unwrap_or_default()
	))
	}

I'll try to remember to PR when I got time :)

[richardwesthaver]

fixed by: richardwesthaver@15a2c67