Giter Site home page Giter Site logo

Comments (6)

lpnh avatar lpnh commented on September 21, 2024

Yep, I can confirm that. The good news is that it seems to have already been fixed in the main branch, so if you can build Nu from source, that should resolve this issue.

from nushell.

MaxGrekhov avatar MaxGrekhov commented on September 21, 2024
TLDR: I'm not a Rust developer and can't help you with that. With all due respect, I'm frustrated. I downloaded this package, tried the first command and folder, and faced this error. I spent three hours trying to understand why I was so stupid, and it didn't work. It's one of the crucial commands that can be in a shell. It just doesn't fit in my mind How incoming input can affect the call of the function and parameters. It looks like a leaking of execution control to input data, which is a security issue. I would suggest reconsidering some architectural decisions.

from nushell.

NotTheDr01ds avatar NotTheDr01ds commented on September 21, 2024

Looks like a duplicate of #12429 which was closed with #12625. Reading through the root issue, I don't see any security concerns there. Sorry to hear you ran into this on your try. Globbing, path handling, strings->path, etc. are areas that have seen a lot of recent changes, and I'm expecting (as a user) that it's still not finalized.

from nushell.

MaxGrekhov avatar MaxGrekhov commented on September 21, 2024

I won't insist on anything because I don't know. I like the idea behind this project. However, from a high-level review, it's less popular than the fish shell, so the base of people who would report issues should be smaller. Still, there are three times more issues. Maybe you could prioritize the stabilization instead of the new features.
I hope the project will make it through, and I'll give it another chance later. Thank you for your time.

from nushell.

NotTheDr01ds avatar NotTheDr01ds commented on September 21, 2024

I've used Fish for many years, and it's a great shell. While I've recently switched to Nushell as my daily-driver, I can certainly understand that you want to use a more stable shell. For me, the advantages of Nushell now outweigh its disadvantages, but that will differ for each individual's needs.

However, I do think that "total issues" is a poor comparison between the two shells, for multiple reasons. I don't think anyone would disagree that there are more issues with Nu at the moment than with Fish. That's pretty much expected when:

  • The first Fish stable release was more than 10 years ago, with more than 8 years of development prior to that. From "first commits", Fish is almost four times older than Nushell.
  • The maintainers of Nushell are clear that it is still pre-release. There are still fixes and features (IMHO, as a user) that will certainly be needed to get to 1.0. If it were to follow the Fish development cycle, it would still have another 3 years to go before it hits 1.0. I'm not saying that's going to be the case - I think Nushell's development so far (and to come) has been far more rapid than that of early Fish.

And Nushell is, arguably, a far more ambitious project:

  • Nushell has 443 built-in commands (help commands | length), over a dozen different data formats, a plugin system (even more data formats and commands), a standard library (yet again, even more formats and commands), and an advanced type system
  • Fish has 61 built-in commands (builtin --names | wc -l)

Finally, I'm not sure how to truly gauge "popularity" of the two shells. It's interesting to note that Nushell has 30k stars on GitHub compared to Fish's 25k, but that could simply be due to Nushell being in active development, so more people gravitate to the GitHub site than with Fish.

Side-note: While GitHub has me listed as a "contributor", I'm not a Rust developer either. I've just fixed a few help topics, docs, and scripts. I'm pretty much just an end-user like you.

from nushell.

arnfaldur avatar arnfaldur commented on September 21, 2024

As per the discussion, the issue can be closed.

from nushell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.