Giter Site home page Giter Site logo

Comments (6)

ChrisDenton avatar ChrisDenton commented on July 22, 2024 1

ImDisk doesn't properly integrate with the system mount manager so some Windows API functions will return errors when querying the drive. In particular this is a problem for canonicalize.

I had thought nushell had worked around this when it stopped relying on canonicalizing paths but it seems not.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

We would accept a PR to fix this. I have no idea what's going on here.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

We use canonicalize pretty heavily, so that may be the problem.

from nushell.

devyn avatar devyn commented on July 22, 2024

Is there any big reason why we shouldn't just replace most cases of canonicalize with expand_path?

It seems like that tends to reflect user intent more often, and avoids issues like this where you can do a lot of filesystem operations on paths but they don't actually exist in any kind of normal form.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

@devyn Have you seen this? Maybe it's a better approach? #12978

from nushell.

devyn avatar devyn commented on July 22, 2024

@fdncred oh yeah, that looks great! Thanks for pointing that out to me. I think figuring out something even if it's a bit more complex that better reflects user intent and works more often is good

from nushell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.