Giter Site home page Giter Site logo

Comments (5)

NotTheDr01ds avatar NotTheDr01ds commented on July 22, 2024 1

I don't want to remove the examples, but rather fix them somehow in the code.

Sounds good to me, and I've edited the issue to reflect that. I also looked at this a bit last week to see if I could do anything about it, but didn't come up with anything either. Of course, you have a much better chance than I do ;-)

But regardless, I'll leave this open as an issue on the core itself rather than removing the examples.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

I don't want to remove the examples, but rather fix them somehow in the code.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

I played around with this in documentation.rs, just trying to hard-code all tables to --expand but couldn't get it to work. I'm probably missing some key concept here.

image

from nushell.

NotTheDr01ds avatar NotTheDr01ds commented on July 22, 2024

I'm probably missing some key concept here.

Actually, you almost nailed it. If you check your implementation against help zip, you'll see that it works.

The problem with help table is that the actual hardcoded results are wrong.

I've fixed the table --expand result, but I'm not sure that help --collapse is fixable without being able to conditionally run --compact against it. That result "table" can't (I don't believe) be represented in Rust. Please correct me if I'm wrong.

I think perhaps I could attach a --collapse in the table.rs example itself, but I'm not sure yet.

from nushell.

fdncred avatar fdncred commented on July 22, 2024

The problem with help table is that the actual hardcoded results are wrong.

doh! that explains it then.

what i was thinking of doing when i wrote that code was to check the example.example to see if it ended with --expand or --collapse and then change the call appropriately before passing it into .run()

from nushell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.