make the completer return the strings (or positions of them) that are used for completing

[maxomatic458]

make the completer return the strings (or positions of them) that are used for completing

[maxomatic458]

turns out each suggestion already includes the range in question.
so a base implementation does the trick

[fdncred]

I'm up for whatever. BTW - I've never really liked Levenstein completions. I always thought alphabetical was better.

[fdncred]

Seems plausible but sounds like it would be a breaking api change. Not that we're against that but seems like it may be tricky to retrofit in nushell. Maybe I'm wrong?

[maxomatic458]

i guess we could make a seperate function for this then, but i feel like this just makes things unnecessarily complicated

But if we would do that, then there wont be any breaking changes

Edit: actually i think having a seperate function would probably be the better way to go

[fdncred]

Separate function sounds great. If you put a //TODO in there around the function, to sometime consolidate functions, we can decide at a later point how important it is and if it's worth a breaking change. Thanks for bringing up this topic.

[maxomatic458]

to make this function "optional" then
should i have a default implementation that panics or returns default values, when its not explicitly implemented?

something like this

pub trait Completer: Send {
    /// the action that will take the line and position and convert it to a vector of completions, which include the
    /// span to replace and the contents of that replacement
    fn complete(&mut self, line: &str, pos: usize) -> Vec<Suggestion>;
    
    /// complete, but also return the index of the start of the string being completed
    fn complete_with_start(&mut self, line: &str, pos: usize) -> (Vec<Suggestion>, usize) {
        panic!("Not implemented")
    }
    ...
}

[fdncred]

Is it possible to have complete_with_start call complete if complete_with_start isn't implemented? Kind of uses the default implementation of complete if complete_with_start isn't implemented.

[maxomatic458]

@fdncred that would only work if we can assume that the suggestions starts with the last part of the line. then the start position can be calculated from that. otherwise (if the completer uses a different way, like levensthein distance of the last word or so)
then this will return a wrong value

but you could also return a default position like 0, but i think it would be better to panic then returning something potentially wrong

[maxomatic458]

all of the current menus that support this can just do this

impl Completer for DefaultCompleter {
    fn complete(&mut self, line: &str, pos: usize) -> Vec<Suggestion> {
        complete_with_start(&mut self, line: &str, pos: usize).0
    }
    
    fn complete_with_start(&mut self, line: &str, pos: usize) -> (Vec<Suggestion>, usize) {
        ...
    }
    ...
}