Giter Site home page Giter Site logo

Comments (3)

ethman avatar ethman commented on June 10, 2024

I've been thinking a lot about this, and I think this would muddy up the interface for a lot of the algorithms. This is due to the fact that python isn't strongly typed, so we can't overload the constructor, meaning that we'd have to do a lot of extra logic at the beginning of every separation base constructor just to get everything set up correctly. Whereas for the user, it's one more line of code before the constructor. I see this as a whole lot of work just to save one line of code for the user.

Additionally, all SeparationBase algorithms should be returning AudioSignal objects and it seems imbalanced to input an array and output a completely different object.

I'll leave this open for now to see what other people's thoughts are.

from nussl.

pseeth avatar pseeth commented on June 10, 2024

I think this was mostly a workaround from before when the AudioSignal interface wasn't as good as the librosa interface (this is down to the duration/offset arguments that were in librosa but not in AudioSignal). Now that the interfaces are basically the same, it's fine the way it is. I'm fine closing this as "wontfix".

from nussl.

ethman avatar ethman commented on June 10, 2024

Sounds good.

from nussl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.