Comments (3)
I've been thinking a lot about this, and I think this would muddy up the interface for a lot of the algorithms. This is due to the fact that python isn't strongly typed, so we can't overload the constructor, meaning that we'd have to do a lot of extra logic at the beginning of every separation base constructor just to get everything set up correctly. Whereas for the user, it's one more line of code before the constructor. I see this as a whole lot of work just to save one line of code for the user.
Additionally, all SeparationBase algorithms should be returning AudioSignal objects and it seems imbalanced to input an array and output a completely different object.
I'll leave this open for now to see what other people's thoughts are.
from nussl.
I think this was mostly a workaround from before when the AudioSignal interface wasn't as good as the librosa interface (this is down to the duration/offset arguments that were in librosa but not in AudioSignal). Now that the interfaces are basically the same, it's fine the way it is. I'm fine closing this as "wontfix".
from nussl.
Sounds good.
from nussl.
Related Issues (20)
- Issue with rfft on Colab due to updated version of PyTorch
- Remove MaskBase & all downstream dependencies
- Scaper OTF Datasets
- HuggingFace Integration
- Tensor-based AudioSignal
- Remove Caching
- Remove Transforms
- Remove SeparationModel
- SalientExcerptMixSrc Dataset
- Speech Separation
- Can't run the deep learning based source separation model HOT 3
- Can I train a deep learning model with an own made dataset?
- Can anyone help me install nussl please? Issue with soxbindings requirement.. HOT 6
- repet object's "interact" method passes wrong argument to gradio
- About metadata HOT 1
- AttributeError: module 'librosa.display' has no attribute 'waveplot' HOT 2
- No Module named audio_signal Python 3.9
- Appropriate module versions for nussl? HOT 3
- AudioSigna.stft() not updating stft_data and stft_params?
- nussl.datasets.MUSDB18(download=True, subsets=['train'])
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nussl.