Use generic .twig extension for a better integration with tools like PatternLab

[nuvoleweb]

Use generic .twig extension for a better integration with tools like PatternLab

[tanc]

If its hard coded in ThemeManager I can't see any easy way. A real shame as UI Patterns seems like a great way of wiring Pattern Lab and Drupal together.

[ademarco]

Maybe you can open an issue on PatternLab referencing this one?

[tanc]

My use statement in my yml file looks like:
use: "@organisms/paragraphs/text-image/text-image.twig"

The error thrown is: Twig_Error_Loader: Template "themes/custom/ics_theme/source/_patterns/03-organisms/paragraphs/text-image/text-image.twig/text-image.twig.html.twig" is not defined

[ademarco]

Ha! Nice catch! .html.twig is a Drupal thingie indeed, I'm gonna get rid of it at once! 😄

[ademarco]

@tanc PR created, could you please check if that works for you? Thanks!

[tanc]

There must be a bit more to it as that results in the following error:

Twig_Error_Loader: Template "themes/custom/ics_theme/source/_patterns/03-organisms/paragraphs/text-image/text-image.html.twig" is not defined

For some reason the .html is still there but the directory structure is now correct.

[ademarco]

Yeah I guess that's not really the right fix then. Actually the .html.twig extension is kind of hardcoded in the ThemeManager class, see \Drupal\Core\Theme\ThemeManager::render():

    }
    else {
      $render_function = 'twig_render_template';
      $extension = '.html.twig';

      // The theme engine may use a different extension and a different
      // renderer.
      $theme_engine = $active_theme->getEngine();

So I guess you'll have to name your templates accordantly, would that be possible?

[tanc]

Ah right. That would be a shame as the name of the template is taken from the file name in Pattern Lab so file names would have html in them, like this:

[ademarco]

I see, any way you can override that in PatternLab?

[tanc]

Yes, I can specify the file name in a .md file alongside it. The main problem is I then have to rename all my supporting files to have the .html part of the filename which is HORRIBLE!

[ademarco]

I wonder if there is anything I can do on my side but I guess not since anyway Drupal will try to find files with that extension, right?

[aleksip]

@tanc I agree that having to name files like that because of Pattern Lab is horrible! :)

I'd consider this an issue with Pattern Lab. The .html.twig extension is advocated in Symfony/Twig documentation, so the compatibility issue is not just with Drupal/UI Patterns.

[tanc]

Ahah, good feedback. There is a config setting in Pattern Lab where you can define your extension (currently twig) but there has to be a matching pattern loader rule. I don't know enough about Pattern Lab to know if this is the right direction but it could be a solution.

[ademarco]

Closing as follow up has been opened on PatternLab's.