Comments (8)
Share..... 🧐
Maybe on documentation we can have a list other useful directives.... Its a single file right?
Thanks!
from lighthouse.
Yep, it's a single file. Just submitted a pull request for some changes which are needed for implementing this.
Hmm yeah we could add it in documentations, here is a gist with my directive.
https://gist.github.com/olivernybroe/2d2b164851b4fc7d4b62df8f37bfbb2a
from lighthouse.
@olivernybroe, love the idea and yes that would be awesome to submit a PR for it!! let me know if you have any questions or if there's anything I can help with!
from lighthouse.
@chrissm79 I added a PR for some changes needed, however I didn't add the directive.
The reason why I didn't add the directive is because Scout requires some Laravel features which we don't have in our package, and it would tie Lighthouse to Laravel and make it incompatible with Lumen.
I can add it without tests, or I can create a package so it can easily be added.
(not that great at composer, so it might be possible to add the tests with more knowledge there)
from lighthouse.
Hi @olivernybroe,
I'll be looking into this since I have some experience with testing / porting Laravel libraries to Lumen.
I'm currently not very active with Lighthouse (I'm focussing on the app counterpart that actually consumes the Lighthouse features), but I expect to have time for this in the next couple of weeks..
Kind regards,
Erik
from lighthouse.
Upon a first look, it pitty it that Scout seems to be configured with Algolia (a paid subscription service - only free for open source projects) only. They claim it should be easy to integrate other search indexing services, just sad to see that ElasticSearch is not the preferred interface by default.
I do have some experience with ElasticSearch (and eg. Apache Solr) so I'll take it as a challenge to make Scout work with Lumen AND ElasticSearch instead of Algolia.
from lighthouse.
For the test in lighthouse, we could just use fakes or maybe use TNT search? Just didn't felt like adding the directive without tests for it.
from lighthouse.
@olivernybroe You could add laravel/scout
as a dev
dependency (if there's a way to test it). It will just throw an exception if a user attempts to use the scout directive w/ out the composer package installed, but it means it won't pull it in when Lighthouse is installed in case the user doesn't plan on using scout or if it's incompatible w/ Lumen. Let me know if you have any questions or if there's anything I can help out with!
As for tests, something like this might work.
from lighthouse.
Related Issues (20)
- CanArgs is defined twice in schema-directives.graphql
- `extend scalar X` directives are lost
- @canFind is missing "model" argument in graphql definition HOT 1
- Allow to customize the unique key for `PaginatedModelsLoader`
- artisan lighthouse:union stub appears to be incorrect HOT 1
- Problem with subscription middleware HOT 2
- An error occurs in the SubscriptionRegistry when sending a subscription event via Subscription::broadcast with Laravel Octane (Swoole) HOT 5
- Laravel v11 support dependancy missing
- Enum Support for Morph Types HOT 1
- Mutation transaction seem not work HOT 4
- Failed to find class App\GraphQl\Queries\TodoQuery in namespaces [] for directive @paginate
- @whereNull and @whereNotNull No directive found!
- GraphQL subscription with Laravel Reverb HOT 3
- input.id in @can(find: ) HOT 1
- Throttle directive sets wrong decay time HOT 4
- Allow GraphQL types named like PHP reserved keywords in federation entity resolver HOT 1
- When executing Multiple Operations GraphQL, if an error occurs in the StartExecution event listener, an error that ignores the number of operations is returned. HOT 1
- Offer Automatic persisted queries hash in the context HOT 3
- Nested Mutation Regression in v6.37.1 HOT 4
- Detection of incorrect type usage in input, or vice versa HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.