`thefuck/thefuck/rules/no_command.py` is not cross-platform

[nvbn]

`thefuck/thefuck/rules/no_command.py` is not cross-platform

[nvbn]

There's a settings command_not_found for path to command-not-found.

[sariyamelody]

Are you suggesting that instead of a properly generic method, the correct path is instead simply using command-not-found?

[academo]

I think this is related to #2 and #23

[academo]

@skyhighwings @nvbn I found an implementation of command not found https://github.com/bfontaine/homebrew-command-not-found but it is not actually trying to correct command names but only suggesting to install packages you don't have if you write the right name.

[sariyamelody]

@academo yes, it is related to those :-)

I'd be willing to write a Levenshtein-based command finder later, but I don't know Python nearly as well as I do other languages.

[academo]

@skyhighwings I think you can write them in other languages and then run it into python I don't know python either.

[rperce]

Ah ha! This is perhaps why it doesn't work on Arch Linux.

[sariyamelody]

@rperce that is precisely why it doesn't work on Arch, actually!

[cdipaolo]

I'd love to do this, but I won't be able to do it until this coming weekend. Lot's of work going on. If the timing is a problem let me know and somebody else can take it. A lot of the stuff below is based on @skyhighwings suggestions above

Heres the implementation I think would work best. Suggestions would be welcome:

1. do a $PATH walk and store all executable binaries on a CSV file with a timestamp.
   • include alias names in CSV list
2. on fuck, check if the timestamp is older than some config variable (default 7 days.)
3. if it is older, then rewalk the $PATH.
4. if current, calculate the minimum Lavenstein distance from the CSV list of commands
   • if, while running through the commands, the current minimum is 1 insertion/deletion/modification, then return that command
5. either ask the user or just run the command

Also, there might be a more efficient way of calculating the best word for our purposes rather than using the Lavenstien distance, because running it on a list takes O(words*maxLength^2) which is pretty slow. Although that would be the most accurate, so if you chose another algorithm then it would be probably necessary to prompt the user and ask if the command should be run.

[nvbn]

@cdipaolo, cool idea, thanks. I've implemented something similar, but a bit simpler.

Should be crossplatform in 1.18+.

[sariyamelody]

👍