Plenary.job crashes on Windows

[nvim-lua]

Plenary.job crashes on Windows

[Shatur]

I also tested the code on my Linux machine and everything works correctly.

[Conni2461]

I think args = { '--files', '.' }, should make it work (previously that wasn't necessary only when grepping).
Also see neovim/neovim#13736

[Shatur]

@Conni2461, thanks for the info, updated the first post but still didn't help. The editor crashes.

[Shatur]

Opened the issue in Neovim: neovim/neovim#14484

[clason]

Why? Can you reproduce this without plenary?

[Shatur]

@clason, I think that the editor should never crash, no matter what plugin is used. It should throw an error if something is wrong.

[clason]

But you're calling an out-of-process job via libuv, so it's not clear that it's the editor's fault.

[Shatur]

@clason, sure, this need more investigation.

[clason]

Also, can you try without the sync() to check whether the problem is there rather than in Job:new()?

And try a debug build to see if an assert is triggered.

[Shatur]

And try a debug build to see if an assert is triggered.

Should I build it myself?

[clason]

Yes. (I mean neovim, of course, just to be clear.)

[Shatur]

Also, can you try without the sync() to check whether the problem is there rather than in Job:new()?

Doesn't crash without sync ().

Yes. (I mean neovim, of course, just to be clear.)

Sure. Okay, will take some time, Windows is not a very convenient platform for such things.

[clason]

OK, then the culprit is in sync, specifically. Since @tjdevries is on vacation, maybe our resident async expert @oberblastmeister has an idea why this crashes on Windows?

[clason]

Also, can you add more details (stacktrace) on how it crashes?

[Conni2461]

job:new doesn't really do anything besides creating a job object and since plenary.job is just a wrapper around uv.spawn could you try a minimal script similar to what ndavidq0 did a couple of months ago.

Idk something like this:

local uv = vim.loop

local stdin = uv.new_pipe(false)
local stdout = uv.new_pipe(false)
local stderr = uv.new_pipe(false)

local handle = uv.spawn("rg", {
  args = { '--files' },
  stdio = { stdin, stdout, stderr }
}, function() end)

uv.read_start(stdout, function(err, data)
  assert(not err, err)
  if data then
    print(vim.inspect(data))
  end
end)

uv.read_start(stderr, function() end)

uv.shutdown(stdin, function()
  uv.close(handle, function() end)
end)

[Shatur]

Also, can you add more details (stacktrace) on how it crashes?

How can I do it on Windows?

job:new doesn't really do anything besides creating a job object and since plenary.job is just a wrapper around uv.spawn could you try a minimal script similar to what ndavidq0 did a couple of months ago.

Prints the output and crashes.

[clason]

Also, can you add more details (stacktrace) on how it crashes?

How can I do it on Windows?

I don't know; I haven't touched Windows for more than 15 years. I'm sure StackOverflow can help, though. How are you running neovim (without -qt) in Windows?

job:new doesn't really do anything besides creating a job object and since plenary.job is just a wrapper around uv.spawn could you try a minimal script similar to what ndavidq0 did a couple of months ago.

Prints the output and crashes.

Can you reproduce without neovim (via https://github.com/luvit/luv)?

[Shatur]

I don't know; I haven't touched Windows for more than 15 years. I'm sure StackOverflow can help, though. How are you running neovim (without -qt) in Windows?

I've tried both cases.

Can you reproduce without neovim (via https://github.com/luvit/luv)?

I have not tried it because I don't use Windows as my development environment.

[Shatur]

At the moment I'm trying to build on Windows in debug and see where the crash occurs. I need some time to setup the environment.

[Shatur]

I built the application and its dependencies in debug. When executing the above code, the debugger stops here:

[Shatur]

@Conni2461, with the latest master the following code works just fine:

local uv = vim.loop

local stdin = uv.new_pipe(false)
local stdout = uv.new_pipe(false)
local stderr = uv.new_pipe(false)

local handle = uv.spawn("rg", {
  args = { '--files' },
  stdio = { stdin, stdout, stderr }
}, function() end)

uv.read_start(stdout, function(err, data)
  assert(not err, err)
  if data then
    print(vim.inspect(data))
  end
end)

uv.read_start(stderr, function() end)

uv.shutdown(stdin, function()
  uv.close(handle, function() end)
end)

But the code from the my first message still crashes the editor. I assume that this is a Plenary issue. Can I somehow provide more information to help to fix it?

[tjdevries]

maybe it's out of memory? how many files are getting stored? where are you running it from?

[Shatur]

maybe it's out of memory? how many files are getting stored? where are you running it from?

Tried different folders even with one text file, the result is the same.

Maybe I can try running other examples to see which part of Plenary is crashing? Like with uv.spawn.

[Shatur]

The issue was in repgrep itself, check nvim-pack/nvim-spectre#5 (comment)