Plenary job fails with environment variables

[nvim-lua]

Plenary job fails with environment variables

[pwntester]

Im using v0.6.0-dev+26-g9c7e04eb3 on MacOS Big Sur

I printed the options var on line 388 of lua.job and got:

{
  args = { "auth", "status" },
  command = "gh",
  env = { "NO_COLOR=1" },
  stdio = { <userdata 1>, <userdata 2>, <userdata 3> }
}

Also, printing self.pid after the call to spawn Im getting ENOENT: no such file or directory

When not using the env, I get:

{
  args = { "auth", "status" },
  command = "gh",
  stdio = { <userdata 1>, <userdata 2>, <userdata 3> }
}

and self.pid returns a correct pid

[Conni2461]

Can you run make test (i dont know if plenary busted even works on mac os) so you might only want to try this:

plenary.nvim/tests/plenary/job_spec.lua

Lines 98 to 110 in ca51b68

	local results = {}
	local job = Job:new {
	command = 'env',
	env = { 'A=100' },
	on_stdout = function(_, data)
	table.insert(results, data)
	end,
	}
	job:sync()
	assert.are.same(job:result(), { 'A=100' })
	assert.are.same(job:result(), results)

And i am currently writing libuv c script to figure out where the problem is.

Another thing would be to write a luv script and check that. I will send you more snippets :)

[pwntester]

Just found out that passing the absolute path to spawn's command make it work:

  local job =
    Job:new(
    {
      enable_recording = true,
      command = "/usr/local/bin/gh",
      args = opts.args,
      on_exit = vim.schedule_wrap(
        function(j_self, _, _)
          if mode == "async" and opts.cb then
            local output = table.concat(j_self:result(), "\n")
            local stderr = table.concat(j_self:stderr_result(), "\n")
            opts.cb(output, stderr)
          end
        end
      ),
      env = { NO_COLOR = 1 },
    }
  )
  if mode == "sync" then

Which is inconvenient since I have to figure out the path myself before calling gh.
Not sure what the reason is, maybe, passing an env table with only one var, overrides all PATH 🤔

[pwntester]

Not sure what the reason is, maybe, passing an env table with only one var, overrides all PATH

Yep, that seems to be the case since gh is no longer authenticated when setting the NO_COLOR var.
I think the solution would be to merge vim.env with the passed env table. Does it make sense?

[Conni2461]

Maybe try { path = vim.env["PATH"], NO_COLOR = 1 }

[Conni2461]

We can't merge the tables we cant look in vim.env table, because its a metatable.

[pwntester]

Maybe try { path = vim.env["PATH"], NO_COLOR = 1 }

That seems to be enough to get gh working. Thanks!

[Conni2461]

I would just pick the once you need? According to libuv docs if env is NULL it will take the parent environment: http://docs.libuv.org/en/v1.x/process.html#c.uv_process_options_t.env

[pwntester]

Wondering why does it work for you on linux then 🤔

[stevenhansel]

Can confirm that this happens to me too on MacOS M1 @pwntester
I used the absolute path solution that you mentioned and it worked fine for me now