Bug: Filetype icon for terminal acting weird

[MarcoBuess]

Bug: Filetype icon for terminal acting weird

[arsmoriendy]

Unfortunately some of my tests failed. One of the reason being that the filetype component test only simulates the buffer's filename and not the filetype (line 303 in component_spec.lua) . I will try to look further into it this weekend.

[MarcoBuess]

I just tested devicons.get_icon_by_filetype(vim.bo.filetype) which is returning the correct icon/highlight group while in the affected buffer.

[MarcoBuess]

So the problem lies somewhere here:
https://github.com/nvim-lualine/lualine.nvim/blob/0a5a66803c7407767b799067986b4dc3036e1983/lua/lualine/components/filetype.lua#L34C34-L34C73

Lines 35-37 would potentially recover the problem but don't get triggert as icon != null. Any particular reason why getting the icon like that instead of just using vim.bo.filetype in general? vim.bo.filetype would also kinda allow the users to make small modifications by changing a buffers file type, which might be a good thing?

[MarcoBuess]

Seems like @arsmoriendy already found the same thing and filed a PR: #1252