Giter Site home page Giter Site logo

Comments (16)

zcbenz avatar zcbenz commented on May 9, 2024

It's a harder bug than I have thought, now we don't have symbols issues but we get crash when creating V8 values in native modules, which seems to be caused by different V8 versions used by node and node-webkit.

from nw.js.

pauliusuza avatar pauliusuza commented on May 9, 2024

any update on this?

from nw.js.

zcbenz avatar zcbenz commented on May 9, 2024

I had tried to solve it last month, according to how node.js had done. After that I got no symbols not founding errors, but got stuck by mysterious assertion when creating V8 handles. Then I gave up because it's rather slow to build and to debug node-webkit on my Windows virtual machine.

I'll have a try again next week.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

We would like to fix this before releasing 0.3.2

from nw.js.

pauliusuza avatar pauliusuza commented on May 9, 2024

thanks for the update, would be really useful to have this in 0.3.2

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

As we modified Node to use the version of V8 in chromium, the ABI is changed. And native module is built with node-gyp with the upstream Node, then the ABI breaks when the module is loaded.

We should provide the headers and the import library of our version to node-gyp in some convenient way.

from nw.js.

zcbenz avatar zcbenz commented on May 9, 2024

I had tried to replace the V8 chromium uses with the node's one, but still got the same error, and if this is the reason then native modules on other platforms should all break.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

Please use the chromium version of V8.

On linux and OSX the linking is different with windows, which need an import library. So the condition is different.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

@zcbenz , third party native modules have to link with our Node, not upstream's. On Linux and OSX it might tolerant more in the ABI specification and didn't trigger the error, but we should look into it later and fix Windows first.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

I just verified that if linking with our Node (nw.lib), the native module works well. So we'll place the dev files (nw.lib, nw.exp and headers) on our download server starting from the next release. We'll also see if node-gyp can use our files directly, or we'll provide a hacked version of node-gyp in npm.

from nw.js.

pauliusuza avatar pauliusuza commented on May 9, 2024

That's great, looking forward to the release.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

fixed with a new tool https://github.com/rogerwang/nw-gyp. will be released with 0.3.2

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

Wiki: https://github.com/rogerwang/node-webkit/wiki/Build-native-modules-with-nw-gyp

from nw.js.

vinnitu avatar vinnitu commented on May 9, 2024

I return to my app idea with ltx module, but still failed to run app :(
I have read about nw-gyp but something wrong with configure it :((
As I understand node-gyp must link ltx (expat) with custom nw.lib? or what is solution?

Sorry for my poor english.

from nw.js.

rogerwang avatar rogerwang commented on May 9, 2024

I replied to you in your issue of nw-gyp project.

from nw.js.

vinnitu avatar vinnitu commented on May 9, 2024

So thank you again! :)

from nw.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.