Giter Site home page Giter Site logo

ZIP destination consistency about nw-updater HOT 9 CLOSED

nwutils avatar nwutils commented on August 15, 2024
ZIP destination consistency

from nw-updater.

Comments (9)

edjafarov avatar edjafarov commented on August 15, 2024

yes I agree that tempDirectory/a/b.js makes sense for windows and linux.
the mac have app as a folder appName.app which is ok as it is.

from nw-updater.

adam-lynch avatar adam-lynch commented on August 15, 2024

the mac have app as a folder appName.app which is ok as it is.

Does that apply to just when you're using DMGs or ZIps as well?

from nw-updater.

edjafarov avatar edjafarov commented on August 15, 2024

zip as well. The app in mac is a folder. You can run it. open appName.app though it is also a folder and you can just change it's content.

from nw-updater.

adam-lynch avatar adam-lynch commented on August 15, 2024

Oh, but I mean they could still have a ZIP with a/b/c.app inside. I've making these sort of changes on my custom-names branch.

from nw-updater.

edjafarov avatar edjafarov commented on August 15, 2024

they may have. Though to copy stuff properly we have a restriction that there should be a single folder in the package at a root level. For win and linux we have several files generated by webkit-builder thus they have to be in a folder. For mac we have single folder as executable thus it may be at a root level.

from nw-updater.

adam-lynch avatar adam-lynch commented on August 15, 2024

Though to copy stuff properly we have a restriction that there should be a single folder in the package at a root level.

Well, we will always because it'll be inside a package (ZIP, etc.) and the ZIP's basename is used to create a folder.

Have a good look at #37 and tell if something doesn't make sense.

from nw-updater.

edjafarov avatar edjafarov commented on August 15, 2024

I guess with #37 it finally does makes sense, thanks!

from nw-updater.

adam-lynch avatar adam-lynch commented on August 15, 2024

😄

from nw-updater.

adam-lynch avatar adam-lynch commented on August 15, 2024

Closing since #37 is merged

from nw-updater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.