Capacitor: On 16.2 node modules get removed after sync step

[arendjantetteroo]

Capacitor: On 16.2 node modules get removed after sync step

[DominikPieper]

@arendjantetteroo I added a option to preserve the node_modules folder

[DominikPieper]

@arendjantetteroo ah damn. It was to late yesterday ^^'

[arendjantetteroo]

@DominikPieper i tried on 16.2.1 but i'm probably doing something wrong.

I've got this step in my app/project.json file:

"sync": {
      "executor": "@nxext/capacitor:cap",
      "options": {
        "cmd": "sync",
        "preserveProjectNodeModules": true
      },
      "configurations": {
        "ios": {
          "cmd": "sync ios"
        },
        "android": {
          "cmd": "sync android"
        }
      }
    },

and then run with "app:sync" and still get this output:

[info] Sync finished in 0.249s


Removing node_modules from project root...

Should that option be somewhere else in my config?

[arendjantetteroo]

@DominikPieper

Looking at the generated js code in my node_modules i see this:

if ((0, fs_1.existsSync)(nodeModulesPath) && preserveProjectNodeModules) {
            try {
                devkit_1.logger.info(`\n\nRemoving node_modules from project root...`);
                (0, fs_1.rmSync)(nodeModulesPath, { recursive: true, force: true });
            }
            catch (err) {
                devkit_1.logger.error(`\n\nFailed to remove node_modules from project root.`);
            }
        }

So if i use preserveNodeModules = false in my project.json, i get the behaviour i expect. But that naming seems inverted?
I would expect preserve = true to keep my node_modules.

[arendjantetteroo]

@DominikPieper it happens, i'm happy you already got back to this issue so quickly in the first place. :)

[DominikPieper]

@arendjantetteroo merged it. I'll do a hotfix release soon. Don't mind the failed run. That's the ionic-react linter tests. I have to fix the linter setup

[arendjantetteroo]

@DominikPieper thanks, greatly appreciated!