nyroModal with header and footer

[nyrodev]

nyroModal with header and footer

[nyroDev]

It could be a good idea.
I'm pretty sure we can do that with a simple filter.
Basically you need to append and prepend some HTML values inside the content, right?

[Taimar]

I’m not sure what do you mean by “need to append and prepend some HTML values inside the content”.

I think nyroModal could have following options (false and null by default):

nyroHeader: true,
nyroHeaderContent: '<h1>Title</h1> <p><a class="nyroModalClose" href="#">Close</a></p>',
nyroFooter: true,
nyroFooterContent: '<p class="action"><input type="submit" value="Save"> <input type="reset" value="Cancel"></p>'

…and/or:

nyroHeader: true,
nyroHeaderElement: '#modalwin1-header',
nyroFooter: true,
nyroFooterElement: '#modalwin1-footer'

…and/or:

nyroHeader: true,
nyroHeaderElement: this.find('.modal-header:eq(0)'),
nyroFooter: true,
nyroFooterElement: this.find('.modal-footer:eq(0)')

It would be great if we can enable/disable header and footer separately as show above.

Does it make sense?

[nyroDev]

Yes it makes sense.
As I said, this won't be included in the core. Instead, I'll do it in a filter so only person who need this feature will download and incldue it.

[Taimar]

Great!

By the way, I think the logic behind second and third example is the best because:

1. Developers can define header and footer elements by any jQuery selector and automatically for all similar nyroModal instances.
2. All the HTML markup can be located in one place.

[nyroDev]

The developper will have to provide a HTML string OR a DOM element or anything he want. He will have to care about where it comes from.
I'll simply use the content of it with the function append and preprend on the content of the modal, just after the orgiinal content has been inserted.

[Taimar]

Sounds good. I’m eager to try out. :)

[nyroDev]

Add imageRegex parameter in nmObject and use it in image filter. #Closed by 8f2a6a4
Fix CSS error. Closed by 8f2a6a4
Add header and footer parameter in nmObject. Closed by 8f2a6a4

[Taimar]

Could you provide a demo on your site with header and footer enabled? I'm not sure it works in a way I intended it to work.

I'm getting this result (the whole nyromodal scrolls, footer is hidden):
http://i56.tinypic.com/2qbua8h.png

...but the desirable result is this one (only the content scrolls, header and footer are always visible): http://i52.tinypic.com/a47st3.png

Thanks.

[nyroDev]

@tainmar, you have to do so using CSS.
I don't have time for now to explain that, but use position absolute and relative might do the trick.