Comments (9)
It could be a good idea.
I'm pretty sure we can do that with a simple filter.
Basically you need to append and prepend some HTML values inside the content, right?
from nyromodal.
I’m not sure what do you mean by “need to append and prepend some HTML values inside the content”.
I think nyroModal could have following options (false and null by default):
nyroHeader: true,
nyroHeaderContent: '<h1>Title</h1> <p><a class="nyroModalClose" href="#">Close</a></p>',
nyroFooter: true,
nyroFooterContent: '<p class="action"><input type="submit" value="Save"> <input type="reset" value="Cancel"></p>'
…and/or:
nyroHeader: true,
nyroHeaderElement: '#modalwin1-header',
nyroFooter: true,
nyroFooterElement: '#modalwin1-footer'
…and/or:
nyroHeader: true,
nyroHeaderElement: this.find('.modal-header:eq(0)'),
nyroFooter: true,
nyroFooterElement: this.find('.modal-footer:eq(0)')
It would be great if we can enable/disable header and footer separately as show above.
Does it make sense?
from nyromodal.
Yes it makes sense.
As I said, this won't be included in the core. Instead, I'll do it in a filter so only person who need this feature will download and incldue it.
from nyromodal.
Great!
By the way, I think the logic behind second and third example is the best because:
- Developers can define header and footer elements by any jQuery selector and automatically for all similar nyroModal instances.
- All the HTML markup can be located in one place.
from nyromodal.
The developper will have to provide a HTML string OR a DOM element or anything he want. He will have to care about where it comes from.
I'll simply use the content of it with the function append and preprend on the content of the modal, just after the orgiinal content has been inserted.
from nyromodal.
Sounds good. I’m eager to try out. :)
from nyromodal.
Add imageRegex parameter in nmObject and use it in image filter. #Closed by 8f2a6a4
Fix CSS error. Closed by 8f2a6a4
Add header and footer parameter in nmObject. Closed by 8f2a6a4
from nyromodal.
Could you provide a demo on your site with header and footer enabled? I'm not sure it works in a way I intended it to work.
I'm getting this result (the whole nyromodal scrolls, footer is hidden):
http://i56.tinypic.com/2qbua8h.png
...but the desirable result is this one (only the content scrolls, header and footer are always visible): http://i52.tinypic.com/a47st3.png
Thanks.
from nyromodal.
@tainmar, you have to do so using CSS.
I don't have time for now to explain that, but use position absolute and relative might do the trick.
from nyromodal.
Related Issues (20)
- Modal stop working (table navigation) HOT 2
- Photo Gallery Question HOT 3
- submit form in nyroModal with Firefox HOT 3
- TypeError: $(...).nyroModal is not a function HOT 6
- Close button cannot reposition when the modal execute resize HOT 2
- Call nyromodal from AJAX HOT 1
- please give an working full example with object, function, settings .. for a resize animation (like it was default in versions 1.6 .) #254 HOT 2
- Multiple popups HOT 2
- link param can not contain characters "tiff" HOT 1
- Disable closeOnClick after key down
- $.nyroModalSettings is not a function HOT 3
- type: 'iframe'
- 1.6 to 2 conversion - unable to figure out conversion
- nyroModal or other popup with image map HOT 1
- Jquery 3 Workaround
- "An error occured" gallery previous next size stucks
- Uncaught ReferenceError: ..... is not defined
- Iframe modal no longer works in CHROME
- Tab disappears when switching to https://
- myroModal position way out in android
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nyromodal.