Giter Site home page Giter Site logo

Comments (3)

minad avatar minad commented on August 20, 2024

completion-category-overrides is for user-specific overrides. Eglot should probably rather use completion-category-defaults? However this will still leave us with the problem. Orderless recommends to reset these variables to ensure that you get a consistent Orderless UI everywhere. Unfortunately completion-category-defaults comes with many presets which are not really necessary and which lead to an inconsistent UI. On Emacs 28:

(defvar completion-category-defaults
  '((buffer (styles . (basic substring)))
    (unicode-name (styles . (basic substring)))
    ;; A new style that combines substring and pcm might be better,
    ;; e.g. one that does not anchor to bos.
    (project-file (styles . (substring)))
    (xref-location (styles . (substring)))
    (info-menu (styles . (basic substring)))
    (symbol-help (styles . (basic shorthand substring))))

We could recommend instead in the README that the user should remove the undesired entries from the list, e.g.,

(setq completion-category-defaults
      (assq-delete-all 'buffer completion-category-defaults))
(setq completion-category-defaults
      (assq-delete-all 'unicode-name completion-category-defaults))
...

At least a warning in the readme would be appropriate.

from orderless.

minad avatar minad commented on August 20, 2024

The same issue applies to the Corfu and Vertico READMEs. Also some packages modify the completion-category-defaults variable afterwards, e.g., message.el adds (email (styles substring)) which is unnecessary given Orderless. My configuration even contains this:

(with-eval-after-load 'message
   (setq completion-category-defaults
           (delete '(email (styles substring))
                   completion-category-defaults)))

The impact of all these overrides is quite minimal (positively and negatively), but at least I've read reports before where people were confused that Orderless didn't set in properly due to the unexpected overrides.

from orderless.

Andre0991 avatar Andre0991 commented on August 20, 2024

Indeed, having a consistent experience seems like the best default recommended configuration. Maybe the README could warn users about the caveats. But maybe not. Thanks for the explanation!

from orderless.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.