Multi user broken

[oasis-learn-study]

Multi user broken

[vorburger]

This seems to happen because the "code" (token) is missing here:

[08:23:54 INFO] [ch.vorburger.minecraft.storeys.web.ActionsConsumer]: Handling message received on EventBus: {
  "action" : "registerCondition",
  "condition" : "newCmddemo"
}

[08:34:42 INFO] [ch.vorburger.minecraft.storeys.web.ActionsConsumer]: Handling message received on EventBus: {
  "action" : "setTitle",
  "text" : "Welcome!"
}

but how is this possible, in line 94 or 54 of index.ts we seems to always set the code?

DId code got (re?)set to undefined on the TS/JS side already, and Vert.x hides properties with null?

[edewit]

one problem I see is that 2 user can't both have a command that is called 'demo' that does different things. And another problem is that the command registers a bit fast if I type 'my-demo' I end up with commands for 'm' and 'my' all the way up to 'my-demo'

[edewit]

also here, when we don't find the player maybe not set it to null

[edewit]

So the source of this problem is that the event bus sends and both either of the 2 connected session receive the last new loggedIn event. So after that only one is still logged in. See: https://vertx.io/docs/vertx-core/java/#_the_theory

"Sending a message will result in only one handler registered at the address receiving the message.
This is the point to point messaging pattern. The handler is chosen in a non-strict round-robin fashion."

[vorburger]

#37 and #35 seem to have fixed this, as far as I can see... THANK YOU @edewit

I'm keeping this open until we are sure that we are not missing anything - I'm still testing.

[vorburger]

I've found 2 other issues, but -as far as I can tell- have fixed this multi-user problem, so close.

@edewit please re-open if you can spot any other places where we need to switch to reply()...