Add Integer RGB calculation

[obartra]

Add Integer RGB calculation

[obartra]

This sounds really good, do you have a sense for how much SSIM results are affected? I suspect it will be fairly minor. If so I am ok with making it a breaking change, up to you.

Really excited to see your wasm work!

[omnisip]

 ● IVC › should match stored mssims (ssim fast)

    expect(received).toEqual(expected) // deep equality

    - Expected  - 36
    + Received  + 36

    @@ -5,29 +5,29 @@
        "avion_j2000_r3.bmp": 0.936,
        "avion_j2000_r4.bmp": 0.924,
        "avion_j2000_r5.bmp": 0.89,
        "avion_jpeg_r1.bmp": 0.945,
        "avion_jpeg_r2.bmp": 0.937,
    -   "avion_jpeg_r3.bmp": 0.919,
    +   "avion_jpeg_r3.bmp": 0.92,
        "avion_jpeg_r4.bmp": 0.905,
    -   "avion_jpeg_r5.bmp": 0.894,
    +   "avion_jpeg_r5.bmp": 0.893,
        "barba.bmp": 1,
        "barba_flou_f1.bmp": 0.98,
        "barba_flou_f2.bmp": 0.902,
        "barba_flou_f3.bmp": 0.833,
    -   "barba_flou_f4.bmp": 0.796,
    +   "barba_flou_f4.bmp": 0.795,
        "barba_flou_f5.bmp": 0.77,
    -   "barba_j2000_r1.bmp": 0.968,
    +   "barba_j2000_r1.bmp": 0.967,
        "barba_j2000_r2.bmp": 0.948,
        "barba_j2000_r3.bmp": 0.913,
        "barba_j2000_r4.bmp": 0.87,
        "barba_j2000_r5.bmp": 0.781,
        "barba_jpeg_lumichr_r1.bmp": 0.962,
    -   "barba_jpeg_lumichr_r2.bmp": 0.938,
    +   "barba_jpeg_lumichr_r2.bmp": 0.937,
        "barba_jpeg_lumichr_r3.bmp": 0.888,
        "barba_jpeg_lumichr_r4.bmp": 0.835,
    -   "barba_jpeg_lumichr_r5.bmp": 0.801,
    +   "barba_jpeg_lumichr_r5.bmp": 0.8,
        "barba_jpeg_r1.bmp": 0.938,
        "barba_jpeg_r2.bmp": 0.916,
        "barba_jpeg_r3.bmp": 0.882,
        "barba_jpeg_r4.bmp": 0.853,
        "barba_jpeg_r5.bmp": 0.812,
    @@ -48,12 +48,12 @@
        "boats_j2000_r4.bmp": 0.893,
        "boats_j2000_r5.bmp": 0.843,
        "boats_jpeg_r1.bmp": 0.945,
        "boats_jpeg_r2.bmp": 0.935,
        "boats_jpeg_r3.bmp": 0.912,
    -   "boats_jpeg_r4.bmp": 0.896,
    -   "boats_jpeg_r5.bmp": 0.865,
    +   "boats_jpeg_r4.bmp": 0.894,
    +   "boats_jpeg_r5.bmp": 0.864,
        "boats_lar_r1.bmp": 0.845,
        "boats_lar_r2.bmp": 0.896,
        "boats_lar_r3.bmp": 0.911,
        "boats_lar_r4.bmp": 0.938,
        "boats_lar_r5.bmp": 0.957,
    @@ -67,41 +67,41 @@
        "clown_jpeg_lumichr_r2.bmp": 0.871,
        "clown_jpeg_lumichr_r3.bmp": 0.798,
        "clown_jpeg_lumichr_r4.bmp": 0.762,
        "clown_jpeg_lumichr_r5.bmp": 0.677,
        "clown_jpeg_r1.bmp": 0.924,
    -   "clown_jpeg_r2.bmp": 0.9,
    +   "clown_jpeg_r2.bmp": 0.899,
        "clown_jpeg_r3.bmp": 0.876,
        "clown_jpeg_r4.bmp": 0.818,
    -   "clown_jpeg_r5.bmp": 0.806,
    -   "clown_lar_r1.bmp": 0.819,
    +   "clown_jpeg_r5.bmp": 0.805,
    +   "clown_lar_r1.bmp": 0.818,
        "clown_lar_r2.bmp": 0.875,
        "clown_lar_r3.bmp": 0.889,
        "clown_lar_r4.bmp": 0.939,
        "clown_lar_r5.bmp": 0.95,
        "fruit.bmp": 1,
        "fruit_flou_f1.bmp": 0.983,
        "fruit_flou_f2.bmp": 0.913,
    -   "fruit_flou_f3.bmp": 0.858,
    +   "fruit_flou_f3.bmp": 0.857,
        "fruit_flou_f4.bmp": 0.79,
        "fruit_flou_f5.bmp": 0.718,
        "fruit_j2000_r1.bmp": 0.982,
    -   "fruit_j2000_r2.bmp": 0.957,
    +   "fruit_j2000_r2.bmp": 0.956,
        "fruit_j2000_r3.bmp": 0.926,
        "fruit_j2000_r4.bmp": 0.872,
        "fruit_j2000_r5.bmp": 0.827,
    -   "fruit_jpeg_lumichr_r1.bmp": 0.951,
    +   "fruit_jpeg_lumichr_r1.bmp": 0.947,
        "fruit_jpeg_lumichr_r2.bmp": 0.942,
        "fruit_jpeg_lumichr_r3.bmp": 0.881,
        "fruit_jpeg_lumichr_r4.bmp": 0.832,
        "fruit_jpeg_lumichr_r5.bmp": 0.787,
        "fruit_jpeg_r1.bmp": 0.945,
        "fruit_jpeg_r2.bmp": 0.932,
        "fruit_jpeg_r3.bmp": 0.91,
    -   "fruit_jpeg_r4.bmp": 0.863,
    -   "fruit_jpeg_r5.bmp": 0.839,
    -   "fruit_lar_r1.bmp": 0.867,
    +   "fruit_jpeg_r4.bmp": 0.862,
    +   "fruit_jpeg_r5.bmp": 0.838,
    +   "fruit_lar_r1.bmp": 0.866,
        "fruit_lar_r2.bmp": 0.926,
        "fruit_lar_r3.bmp": 0.934,
        "fruit_lar_r4.bmp": 0.955,
        "fruit_lar_r5.bmp": 0.96,
        "house.bmp": 1,
    @@ -110,87 +110,87 @@
        "house_j2000_r3.bmp": 0.934,
        "house_j2000_r4.bmp": 0.892,
        "house_j2000_r5.bmp": 0.83,
        "house_jpeg_r1.bmp": 0.952,
        "house_jpeg_r2.bmp": 0.935,
    -   "house_jpeg_r3.bmp": 0.911,
    +   "house_jpeg_r3.bmp": 0.91,
        "house_jpeg_r4.bmp": 0.872,
        "house_jpeg_r5.bmp": 0.842,
        "house_lar_r1.bmp": 0.868,
        "house_lar_r2.bmp": 0.919,
        "house_lar_r3.bmp": 0.929,
        "house_lar_r4.bmp": 0.95,
        "house_lar_r5.bmp": 0.959,
        "isabe.bmp": 1,
    -   "isabe_j2000_r1.bmp": 0.963,
    +   "isabe_j2000_r1.bmp": 0.962,
        "isabe_j2000_r2.bmp": 0.95,
    -   "isabe_j2000_r3.bmp": 0.919,
    +   "isabe_j2000_r3.bmp": 0.918,
        "isabe_j2000_r4.bmp": 0.909,
    -   "isabe_j2000_r5.bmp": 0.877,
    -   "isabe_jpeg_lumichr_r1.bmp": 0.951,
    +   "isabe_j2000_r5.bmp": 0.876,
    +   "isabe_jpeg_lumichr_r1.bmp": 0.95,
        "isabe_jpeg_lumichr_r2.bmp": 0.933,
        "isabe_jpeg_lumichr_r3.bmp": 0.904,
        "isabe_jpeg_lumichr_r4.bmp": 0.858,
        "isabe_jpeg_lumichr_r5.bmp": 0.811,
        "isabe_jpeg_r1.bmp": 0.904,
    -   "isabe_jpeg_r2.bmp": 0.892,
    +   "isabe_jpeg_r2.bmp": 0.891,
        "isabe_jpeg_r3.bmp": 0.869,
        "isabe_jpeg_r4.bmp": 0.848,
        "isabe_jpeg_r5.bmp": 0.817,
        "lenat.bmp": 1,
        "lenat_flou_f1.bmp": 0.986,
        "lenat_flou_f2.bmp": 0.935,
        "lenat_flou_f3.bmp": 0.89,
        "lenat_flou_f4.bmp": 0.875,
    -   "lenat_flou_f5.bmp": 0.831,
    +   "lenat_flou_f5.bmp": 0.83,
        "lenat_j2000_r1.bmp": 0.973,
        "lenat_j2000_r2.bmp": 0.949,
        "lenat_j2000_r3.bmp": 0.922,
    -   "lenat_j2000_r4.bmp": 0.905,
    +   "lenat_j2000_r4.bmp": 0.904,
        "lenat_j2000_r5.bmp": 0.877,
        "lenat_jpeg_r1.bmp": 0.938,
        "lenat_jpeg_r2.bmp": 0.926,
        "lenat_jpeg_r3.bmp": 0.894,
        "lenat_jpeg_r4.bmp": 0.861,
        "lenat_jpeg_r5.bmp": 0.846,
        "lenat_lar_r1.bmp": 0.884,
    -   "lenat_lar_r2.bmp": 0.919,
    +   "lenat_lar_r2.bmp": 0.918,
        "lenat_lar_r3.bmp": 0.936,
        "lenat_lar_r4.bmp": 0.947,
    -   "lenat_lar_r5.bmp": 0.953,
    +   "lenat_lar_r5.bmp": 0.952,
        "mandr.bmp": 1,
        "mandr_j2000_r1.bmp": 0.895,
        "mandr_j2000_r2.bmp": 0.878,
        "mandr_j2000_r3.bmp": 0.799,
        "mandr_j2000_r4.bmp": 0.678,
    -   "mandr_j2000_r5.bmp": 0.559,
    +   "mandr_j2000_r5.bmp": 0.558,
        "mandr_jpeg_lumichr_r1.bmp": 0.93,
        "mandr_jpeg_lumichr_r2.bmp": 0.913,
    -   "mandr_jpeg_lumichr_r3.bmp": 0.826,
    +   "mandr_jpeg_lumichr_r3.bmp": 0.825,
        "mandr_jpeg_lumichr_r4.bmp": 0.792,
    -   "mandr_jpeg_lumichr_r5.bmp": 0.703,
    +   "mandr_jpeg_lumichr_r5.bmp": 0.702,
        "mandr_jpeg_r1.bmp": 0.893,
        "mandr_jpeg_r2.bmp": 0.84,
    -   "mandr_jpeg_r3.bmp": 0.778,
    +   "mandr_jpeg_r3.bmp": 0.777,
        "mandr_jpeg_r4.bmp": 0.74,
    -   "mandr_jpeg_r5.bmp": 0.684,
    +   "mandr_jpeg_r5.bmp": 0.683,
        "mandr_lar_r1.bmp": 0.702,
        "mandr_lar_r2.bmp": 0.785,
        "mandr_lar_r3.bmp": 0.838,
    -   "mandr_lar_r4.bmp": 0.861,
    +   "mandr_lar_r4.bmp": 0.86,
        "mandr_lar_r5.bmp": 0.895,
        "pimen.bmp": 1,
        "pimen_j2000_r1.bmp": 0.969,
    -   "pimen_j2000_r2.bmp": 0.945,
    +   "pimen_j2000_r2.bmp": 0.944,
        "pimen_j2000_r3.bmp": 0.928,
        "pimen_j2000_r4.bmp": 0.891,
        "pimen_j2000_r5.bmp": 0.783,
    -   "pimen_jpeg_r1.bmp": 0.917,
    +   "pimen_jpeg_r1.bmp": 0.916,
        "pimen_jpeg_r2.bmp": 0.906,
        "pimen_jpeg_r3.bmp": 0.892,
        "pimen_jpeg_r4.bmp": 0.849,
    -   "pimen_jpeg_r5.bmp": 0.817,
    +   "pimen_jpeg_r5.bmp": 0.816,
        "pimen_lar_r1.bmp": 0.897,
        "pimen_lar_r2.bmp": 0.934,
        "pimen_lar_r3.bmp": 0.946,
        "pimen_lar_r4.bmp": 0.955,
        "pimen_lar_r5.bmp": 0.958,

      28 |       );
      29 | 
    > 30 |     expect(scores as MSSIMValues).toEqual(results);

[omnisip]

Do you find this acceptable?

[obartra]

Yeah I think so this is almost the same, how do you feel about it?

[omnisip]

It doesn't affect me, but I think it's a breaking change.

[obartra]

yeah definitely a breaking change but it sounds like a worthy improvement

[omnisip]

Okay. We can support it and make it the new default. I'd like to add backward compatibility options then for anyone who needs the old behavior or has a large test suite depending on matching values.

[obartra]

That's fair, if we keep both approaches then we could make the "original" use the slow one and all other ones use your improved version

[obartra]

🎉 This issue has been resolved in version 3.3.2 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀