Suspicious code in getOptionsArgument

[oblador]

Suspicious code in getOptionsArgument

[oblador]

Yes it's intended, because iOS takes multiple options whereas android does not.

[andriichernenko]

@oblador Is this method supposed to return different things on different platforms then? If this is the case, it would be great to have this documented.

[andriichernenko]

The reason this method drew my attention is that it crashes on Android when I call getGenericPassword(null) (although I should probably create a separate issue for this).

[oblador]

Yup, iOS additional options part should be documented in plain text and not just flow/types.

The native APIs have different signatures yes, so it's required.

Why do you call it with null and not just without arguments?

[andriichernenko]

Why do you call it with null and not just without arguments?

Just a habit from Java/Swift :)
So it won't crash if serviceOrOptions is undefined, right?

[oblador]

Yep, think so!

[oblador]

But you don't have to pass any arguments at all

[andriichernenko]

Okay, thanks for help!