Comments (2)
Thanks to a pairing session today with @kometenstaub - and the merging of the resultant #313 - we now have fully formed Theme
class, and also a new ThemeDownloadCount
class.
In terms of options for what's next...
Possible improvements to the Theme-related code
- It's possible that
ThemeDownloadCount
could be adjusted to store the download data: at the moment, it just contains static methods. - We could also move
ThemeDownloadCount
to its own separate file - I'd like to replace the two calls to
get_json_from_github(THEMES_JSON_FILE)
with aget_community_themes()
that takes care of creating theTheme
objects...- Done: 2022-03-08
- Review uses of
theme.get("field")
andtheme["field"]
- and where possible, replace them with accessor methods.- Done: 2022-03-08
- Then remove
Theme.get()
andTheme.__getitem__()
- Done: 2022-03-08
Possible bigger next steps
- Create a Plugin class
- Done: 2022-03-10
- Create an Author class
- We decided that it was not worth implementing. A link-checking function would be a better way of fixing #143.
from obsidian-hub.
Update from 2022-03-08: We've now finished work on themes.py. The data in Theme is fully encapsulated.
We plan next to implement a Plugin class.
from obsidian-hub.
Related Issues (20)
- Add new content for academic writing HOT 4
- Fix failing Python test HOT 2
- Update 'How to add your theme to the community theme store' for the 1.0 Theme Migration Guide
- '## In The Community' in Roundup post should be at start of the line HOT 10
- Some images for recent themes are broken, HOT 1
- Is it possible to update Obsidian Hub? HOT 3
- Try to fill in missing Roundup articles from spring 2022
- Make update_roundup.py use jinja2 template, so 'This note in GitHub' is added HOT 3
- Where possible, convert GitHub links in roundup pages to internal Hub links
- Download numbers for plugins are inflated HOT 5
- Stenography Plugin obsidian:// link not working
- Deal with duplicate files GitHub Theme/GitHub theme HOT 1
- shared Repository with reference data, similar to Wikipedia and Wikidata HOT 1
- Broken link in one of the guides for Theme Designers (advanced) HOT 2
- We need to detect the default branch in themes and plugins HOT 1
- Plugin/Theme submission guides also need updating for removal of branch from community plugins/themes. HOT 4
- Mermaid diagram example rendering seems broken
- Fix the python_tests GitHub Action HOT 15
- Enable Theme Switcher HOT 3
- Create newer release of Vault
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from obsidian-hub.