Giter Site home page Giter Site logo

Comments (2)

claremacrae avatar claremacrae commented on June 13, 2024

Thanks to a pairing session today with @kometenstaub - and the merging of the resultant #313 - we now have fully formed Theme class, and also a new ThemeDownloadCount class.

In terms of options for what's next...

Possible improvements to the Theme-related code

  • It's possible that ThemeDownloadCount could be adjusted to store the download data: at the moment, it just contains static methods.
  • We could also move ThemeDownloadCount to its own separate file
  • I'd like to replace the two calls to get_json_from_github(THEMES_JSON_FILE) with a get_community_themes() that takes care of creating the Theme objects...
    • Done: 2022-03-08
  • Review uses of theme.get("field") and theme["field"] - and where possible, replace them with accessor methods.
    • Done: 2022-03-08
  • Then remove Theme.get() and Theme.__getitem__()
    • Done: 2022-03-08

Possible bigger next steps

  • Create a Plugin class
    • Done: 2022-03-10
  • Create an Author class
    • We decided that it was not worth implementing. A link-checking function would be a better way of fixing #143.

from obsidian-hub.

claremacrae avatar claremacrae commented on June 13, 2024

Update from 2022-03-08: We've now finished work on themes.py. The data in Theme is fully encapsulated.

We plan next to implement a Plugin class.

from obsidian-hub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.