Giter Site home page Giter Site logo

Comments (6)

akosbalasko avatar akosbalasko commented on June 20, 2024

Hi @przemhb ,
Could you please give us a bit more details about the problematic notes? Do you see any aspect that distinguishes the failed ones from the notes converted correctly? The key point would be that what you recognized, the failure of os.utime().
Thanks a lot!

from obsidian-importer.

przemhb avatar przemhb commented on June 20, 2024

Hi @akosbalasko

just tried to recreate the problem to give you some insight or attach some problematic notes, but... to my surprise another import of the same ENEX resulted in flawless import. But how can it be? The same ENEX, the same Obsidian and Importer. Could it be, that some bug in underlying Python library was fixed in between?

What I have changed for the test was the ENEX filename and selected to put output notes in a folder. The folder did not have " ' " in its name.

from obsidian-importer.

akosbalasko avatar akosbalasko commented on June 20, 2024

@przemhb , it's strange definitely.
But what you mentioned in your first comment made me think: "Interestingly os.utime() failed too". It would mean that something has failed on a deeper level.
I checked the code and fs.utimesSync (os.utime equivalent in NodeJS) is not covered by try-catch, so if it fails, it will make the whole note-conversion fail, even if everything goes well until that point. I think handling possible exceptions in this function would be a good patch.
May I ask what you saw as a failure?

from obsidian-importer.

przemhb avatar przemhb commented on June 20, 2024

@akosbalasko In the case of failed import a note's modification date and time was not set as in the ENEX file, but to current time (or creation time - not 100% sure after those few weeks). As an effect sorting by modification date was flawed with some old notes appearing on the top of the list.

from obsidian-importer.

akosbalasko avatar akosbalasko commented on June 20, 2024

@przemhb , okok thanks! And when you run the import last time, you mentioned that it went well flawlessly. Do you mean that the import itself worked well and set the correct creation dates without the python script?

from obsidian-importer.

przemhb avatar przemhb commented on June 20, 2024

@akosbalasko yes, import alone went just fine, so I wasn't forced to use my python script. Modification dates were as in source ENEX.

from obsidian-importer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.