Comments (3)
I believe it's considered here account.invoice._compute_commission_total
:
# Consider also purchase refunds, although not in the initial scope
if record.type in ('out_refund', 'in_refund'):
record.commission_total = -record.commission_total
But nowhere else (that I can find).
sale.commission.settlement.line.settled_ammount
doesn't hold any values, but instead relates to account.invoice.line.agent.amount
from commission.
You're right. The best is to put the negative on the lines, so in the settlement it appears automatically correct. The only check you should do is if the total is negative (because there are more refunds than invoices), the invoice to create should be a refund.
Can you make a PR with that?
from commission.
OK, I see now the PR, hehe. Then change according comment about the invoice creation, but I see that you have also thought about the same method 😉
from commission.
Related Issues (20)
- Migration to version 16.0 HOT 1
- Manual commission applied to a sales order incorrectly HOT 1
- Commission defined at the sales order, not just the sales order line HOT 4
- Commision base on payment Date HOT 2
- Not computing agent commission (settle commissions command) HOT 8
- Sales Commissions wont calculate HOT 4
- [14.0][BUG] sale_commission: all settles aren't reciving any value
- [QUESTION]: Commission module is ready to migrate from 14 to 15?
- POS commission Calculation HOT 1
- Sales Commission: Settlements based on Sale Order (not needed Invoice) HOT 10
- sale_commission_product_criteria HOT 1
- Migration to version 17.0 HOT 2
- HELP: How do I update from the 13.0 to the 16.0 version of this module without losing my data? HOT 1
- Sales Commission By Sections (Value Ranges) based on the Total of Sale Order not for every Sale Line HOT 1
- [14.0][sale_commission]
- Commission based on paid amounts on invoices HOT 1
- [16.0][RFC]Use Many2one reference to ease the hook with other modules HOT 2
- What is a "manual" settlement? HOT 3
- button fa-users not showing in order lines HOT 2
- [IMP] commission: allow to set specific commissions for partners
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commission.