Error when editing invoice lines

[oca]

Error when editing invoice lines

[pedrobaeza]

This kind of errors happens on the web client side, so there's nothing to do with the current commission code to solve it, but it will be more predictable if we don't use a one2many inside another one2many. Is there something that you figure out for avoiding this one2many?

[ivantodorovich]

Hmm..

To avoid it
I've saw a comment from you in a PR, suggesting to hide commissions lines from invoices with a security group. It's isn't really a fix, but it would avoid errors showing up 99.99% of the times. Since it's almost never needed to edit invoice line comissions manually.

To possible fix it

Maybe we can show a tags-like field where each tag represents a combination of agent and commission. There could be a small button to open a wizard an edit agent lines. I don't know if its possible, though.

Another way to avoid it..

Our use case for commissions is a lot simpler than what's implemented. For instance, we should never set more than 1 commission per invoice line.
Also the agent is a constant in every line, it's only set on a sales order / invoice level.

Maybe we could split this module in 2, provinding a more simple and general approach in the base module and support for multiple agent lines per invoice line in another module.

Again, this isn't a fix. It's rather a workaround for companies that don't need complex commission schemes.

[pedrobaeza]

Yeah, they're workarounds (the last 2, the first one is only to hide the elements) and some of them not easily feasible, but we should find a solution. Let's think a bit more...

[ivantodorovich]

No great ideas from this brain, right now. Maybe something will come up in my sleep.

For now, I'll investigate how security groups work and make a PR, since our company needs some kind of workaround to this error. I mean, hiding is enough to avoid it, right? Or will it still raise errors?

[ivantodorovich]

Related #49 & #25 & #52

[ivantodorovich]

#78 will probably solve it.