[12.0] Can't install module account_e-invoice_generate

[oca]

[12.0] Can't install module account_e-invoice_generate

[astirpe]

It's because module account_e-invoice_generate cannot be installed when standard module account_facturx is already installed. See https://github.com/OCA/edi/blob/12.0/account_e-invoice_generate/__manifest__.py#L15

You should uninstall account_facturx first.

[yucer]

@astirpe Sorry for reopen.
I test this issue again by new database. it's error, when database is not install module account_facturx before.

Step to error :

1. Create new database (with demo data)

2. Install module `account_e-invoice_generate`

But when I install module account_facturx and uninstall, After that I can install module account_e-invoice_generate.
Is it step normal?

That is because the module account_facturx is installed by default in a new database (autoinstall: True)

The first time you create the database you need to uninstall it.

[Saran440]

@astirpe Ahh, I see. Thank you very much :)

[Saran440]

@astirpe Sorry for reopen.
I test this issue again by new database. it's error, when database is not install module account_facturx before.

Step to error :

1. Create new database (with demo data)
2. Install module account_e-invoice_generate

But when I install module account_facturx and uninstall, After that I can install module account_e-invoice_generate.
Is it step normal?

[astirpe]

I agree with you that it's not a nice behavior.
On the other hand, this is the way the 'excludes': ['account_facturx'] line is supposed to work.

I think @alexis-via had good reasons for making that change, let's see if he wants to add any comments on this.

[alexis-via]

I made the change recently in this PR #169
With this change, the PDF attachment of the invoice is stored with the XML data; if attachment_use is True, when you print the invoice again, it will NOT regenerate the XML, it will give you the original PDF file with the original XML attachment.
Unfortunately, it was not possible to implement that without removing the module account_facturx of Odoo SA.

[yucer]

Hello @alexis-via , but you are not using runbot or the unit tests for those PRs right ?

That change was merged without tests ? Is this problem with account_facturx the reason for that ?

I guess that some kind of exclusion should be done for the module account_facturx, because it is marked as autoinstall by Odoo.