Giter Site home page Giter Site logo

Red branch because of use builtin names about edi HOT 4 CLOSED

oca avatar oca commented on July 26, 2024 1
Red branch because of use builtin names

from edi.

Comments (4)

SimoRubi avatar SimoRubi commented on July 26, 2024

In my opinion, I'd rather rename the variables/arguments with something that explains their meaning.
In your example

edi/base_ubl/models/ubl.py

Lines 323 to 329 in 742b131

self._ubl_add_item(
name, product, line_item, ns, type=type, seller=seller,
version=version)
@api.model
def _ubl_add_item(
self, name, product, parent_node, ns, type='purchase',

type could be renamed to line_type or something similar.

from edi.

astirpe avatar astirpe commented on July 26, 2024

@bealdav looking at the link to the travis log that you posted, it seems to me that the red branch is caused by the following error only:

************* Module account_e-invoice_generate

account_e-invoice_generate/readme/INSTALL.rst:6: [E7901(rst-syntax-error), ]  Duplicate explicit target name: "oca/edi".

------------


count_errors 1

pylint expected errors 0, found 1!

from edi.

bealdav avatar bealdav commented on July 26, 2024

You're right @astirpe
pylint fixed by #186
Could you merge ?

from edi.

bealdav avatar bealdav commented on July 26, 2024

OK green now, but we should note to not use builtin names in method for the future

from edi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.