Comments (18)
Could you be more specific?
from hr.
For V7.0, on 09/28/2013 the folder "patches" under "hr_payroll_extension" was deleted.
from hr.
That 's commit a314d8e by @max3903 .
Maybe he can help.
from hr.
I understand that the folder "patches" does not have its place in the OpenERP's Module Folder Structure.
What i want to know is, if the patch is still necessary to make the module work properly, this should be at least, clearly indicated in the manifest file (@ the 'description' section), and put a link to the patch file.
from hr.
Hi @max3903. Was that patch removed intentionally in a314d8e or is it a faulty merge? Thanks!
from hr.
@bwrsandman @max3903 Was the patch obsolete?
from hr.
I can't speak as to why it was deleted, but I don't see why the changes in the patch couldn't be done as a module...
We should not encourage patching the server.
from hr.
@diassynthesis Do you think we can close this?
from hr.
Not yet please. I've posted a message at http://miketelahun.wordpress.com and i'm waiting for a reply
from hr.
If @miketelahun should comment on this, it's best to just mention him as I just did.
I've just reviewed the diff, it's related to the "Need Action" mechanism, not to HR or Payroll.
So it definitely shouldn't be in the module.
I guess I can answer your question: it's not needed.
from hr.
@dreispt Yes, you can close this issue. Just another question (not directly related to this branch, but related to the hr_payroll module): Could you please take a look at odoo/odoo#3916 and tell me what you think about the last lines of the "hr_payroll-hr_payroll.patch".Thank you and best regards.
NB: The related patch is "hr_payroll-hr_payroll.patch"and not the "openobject-server-openerp-addons-base-ir-ir_ui_menu.patch".
from hr.
The file removed in a314d8e is not necessary, as it relates to a useability improvement for ir.need_action
from hr.
Thank you, but are you talking about "openobject-server-openerp-addons-base-ir-ir_ui_menu.patch" or "hr_payroll-hr_payroll.py-patch", or both.
from hr.
I am talking about openobject-server-openerp-addons-base-ir-ir_ui_menu.patch
On 12/13/2014 03:21 PM, diassynthesis wrote:
Thank you, but are you talking about
"openobject-server-openerp-addons-base-ir-ir_ui_menu.patch" or
"hr_payroll-hr_payroll.py-patch", or both.—
Reply to this email directly or view it on GitHub
#19 (comment).
from hr.
What about the "hr_payroll-hr_payroll.py-patch".
from hr.
Still waiting for a response about "hr_payroll-hr_payroll.py-patch". About odoo/odoo#3916 , solved but !!! a new bug revealed odoo/odoo#4363
from hr.
OCA modules shouldn't have bug patches in them.
If you have a bug, open an Odoo issue. For community maintained patches, look at the OCA/OCB project. You can also file the Issue there, but I believe an OCB PR would also be expected. In case you are not able to provide a fix yourself, my honest advice is to seek expert help.
This issue should be closed, since bug fixes are out of scope for OCA modules.
from hr.
@dreispt That's what I've said in my third comment. I will close this issue at the end of this comment. @miketelahun I just want to know, if the "hr_payroll-hr_payroll.py-patch" is needed or not ? Thank you and best regards.
from hr.
Related Issues (20)
- How can I use inputs on salary rules? HOT 1
- Migration to version 16.0 HOT 24
- [14.0][hr_employee_calendar_planning] We cannot create employee from a user HOT 3
- [odoo 15] [hr_contract_employee_calendar_planning] Cant install this module HOT 1
- Attendance throws error "Invalid field 'birth_name' on model 'hr.employee.public'" HOT 4
- hr_org_chart_overview is not showing the title of the employees HOT 2
- conflicts with odoo core function for allocation accrual cron job HOT 1
- [15.0] "psycopg2.errors.InvalidColumnReference: there is no unique or exclusion constraint matching the ON CONFLICT specification" when I try to install hr_employee_calendar_planning HOT 2
- hr_holidays_notify_employee_manager : email template HOT 1
- AttributeError: 'hr.applicant' object attribute 'name' is read-only HOT 2
- [14.0] hr_holidays_settings: duplicated in OCA / hr-holidays repo HOT 2
- can upgrade to odoo 16 Petty Cash HOT 1
- Odoo HR planning HOT 1
- hr_employee_birthday_mail: ValueError: Invalid field 'allow_birthday_wishes' on model 'hr.employee.public' HOT 1
- Using Repo v14.0 for v16.0 HOT 1
- hr_org_chart_overview Multicompany doesn't work HOT 1
- [RFC] module to restrict HR officer to their own subordinates? HOT 1
- Migration to version 17.0 HOT 14
- Data model on hr employee relative is redefining field instead of using oca partner contact modules HOT 2
- hr_employee_ppe: error when assigning multiple PPE to an employee. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hr.