Comments (5)
will do the trick. At first I thought changing these onchange name for standardizing was really invasive. But then I thought at least we don't need to have them in the XML of the views anymore so that wouldn't require lot's of database update right? Only restart, correct? If so seems acceptable.
But still this looks like a basic limitation of the ORM is making us deal with hundreds of side effects in all the modules... I tend to think the ORM would better be fixed at all cost then, for me even if it was only in OCB as I don't really care anymore what SA does or not on its own suicide branch...
from maintainer-tools.
@pedrobaeza
Thanks for information.
Do you have a issue in odoo/odoo for this case?
We can justify this guideline with the answer of issue.
from maintainer-tools.
I don't put any issue to Odoo because it cannot be considered like that, but a feature. I ping Raphael Collet for having his opinion in this issue instead of splitting the debate across multiple issues.
from maintainer-tools.
The convention you propose looks perfectly fine to me.
The other proposal (normalize on onchange_<field_name>
and make the ORM collect them all) looks bug prone and breaks Python conventions. It makes the ORM reinterpret method overriding. What if you actually want to override an existing onchange method?
@pedrobaeza 's convention could be summarized as:
- to add an onchange method on field, define a method
onchange_field_module
decorated with@onchange
; the naming convention avoids accidental name clashes - to modify an existing onchange method, override it like any Python method
from maintainer-tools.
Thanks for the answer, Raphael. Yeah, it makes totally sense to respect Python overriding convention. I'll make the PR with the convention.
from maintainer-tools.
Related Issues (20)
- Migration to version 15.0: --directory option added HOT 5
- oca-migrate-branch: still working? HOT 1
- oca-gen-addon-readme: do not regenerate if content did not change
- [gen-addon-readme] Add support of runboat HOT 5
- Command missing in Wiki page 'Migration to version 15.0' HOT 1
- [RFC] autogenerate INSTALL part of the README file most of the time HOT 7
- [Wiki] migration from 12.0 to 13.0 HOT 1
- Update our tooling to support Odoo 16.0 HOT 19
- Module Migration from v15 to v16 HOT 3
- oca-set-repo-labels: Returns a 404 error HOT 2
- [IMP] Migration to version 16.0 WIKI - web.assets_qweb deprecation HOT 3
- [IMP] Migration to version 15.0 WIKI - xml-deprecated-tree-attribute HOT 2
- unaccent migration guideline is in the wrong version wiki HOT 1
- More documentation relatd to the OCA tools for migrating modules
- [WiKi][FIX] Use temporary reference(s) to another pull request(s) - link structure HOT 6
- isort version to be increased HOT 2
- About squashing bot commits HOT 1
- Bug No package metadata was found for oca-maintainers-tools when generating readme file HOT 6
- [RFC] Updating the README generator automation HOT 29
- Add a new CONTEXT section into README.rst HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maintainer-tools.