Comments (13)
I think the automatic closure should only happen for PRs not tagged as needs review
Yeah that makes sense, and I'm good with that.
An interesting nice-to-have on the note of tags would be a way to have the bot add/remove tags with some sort of comment command.
This would be helpful for contributors that know the tag rules, but don't actually have write access to the repos & even more useful for the PSCs that randomly get pinged just to manage a tag. Admittedly it's usually not me that gets pinged, but I think I see @pedrobaeza's pain on that.
from maintainer-tools.
Add also this one:
- Announce that the PR is ready to be merged if there are 2 approvals, not current comments and there are more than 5 days from the initial request.
from maintainer-tools.
Close and comment ("Please re-open if necessary") every PR older than 6 months without comments
How about:
- One notifications that it will be closed automatically in 7 days
- When closing automatically, add a label
Closed by bot
One more idea for the features
- OCA Karma points: Calculate an "OCA Karma" to promote biggest contributors based on commits, reviews, comments, triage, issue report. Today, people promoted are the one posting apps (open or closed) in apps.odoo, but the one in contributing to one of of the many repositories of OCA don't get much attention. That's mainly because there is no "Cross repository graph", graphs are only at repository level.
from maintainer-tools.
yes, @pedrobaeza's is a very good one. Even better would be if the bot set a label for that, then we can filter for that and merge with just a glance on the comments if there's anything blocking
from maintainer-tools.
Yeah, tagging + mentioning should be the perfect combination!
from maintainer-tools.
Close and comment ("Please re-open if necessary") every PR older than 6 months without comments
Isn't this maybe a bit aggressive? I know I have a bunch of PRs that are good to go and are just waiting for review by someone with time. I feel like if we start closing these types of PRs, we'll end up losing good code.
Maybe some sort of ping before closing?
from maintainer-tools.
Announce that the PR is ready to be merged if there are 2 approvals, not current comments and there are more than 5 days from the initial request.
How is it different from @jgrandguillaume proposal here:
Tag and comment if the pull request is ready to be merged (2 approvals, 5 days, green CI)
from maintainer-tools.
@elicoidal Maybe @jgrandguillaume edited after @pedrobaeza's comment :)
In the actual troubles, we have a rare case, but that might be annoying : OCA/server-tools#689
In short : CI green on the PR, CI green upstream, but CI red when PR is merged with upstream because of some changes applied in the meantime.
If the bot could check this before tagging the PR as mergeable (or comment instead), this would be great (maybe to be added later).
from maintainer-tools.
Isn't this maybe a bit aggressive? I know I have a bunch of PRs that are good to go and are just waiting for review by someone with time. I feel like if we start closing these types of PRs, we'll end up losing good code
@lasley @jgrandguillaume I think the automatic closure should only happen for PRs not tagged as needs review
, that is PRs that need fixing or are WIP or help wanted etc
We should automatically close PRs that nobody is interested in
from maintainer-tools.
#310 supports my previous comment for the need of tags. Is this a v1 feature or a later?
from maintainer-tools.
Is this still open for contribution? @jgrandguillaume
from maintainer-tools.
@zoek1 Yes ! Sorry for late answer. I think it has been started here: #346
from maintainer-tools.
Closing to allow the bounty claim.
from maintainer-tools.
Related Issues (20)
- About squashing translation commits HOT 2
- Update our tooling to support Odoo 17 HOT 20
- Mention `odoo-module-migrator` in migration procedure wiki page HOT 1
- Mention `oca-port` in migration procedure wiki page HOT 6
- oca-gen-addon-readme: exits with no error if `description.rst` is not present HOT 14
- Update migration v17 Wiki HOT 2
- Clarify CONTRIBUTOR.md formatting HOT 20
- Wiki migration 17.0: New Settings format HOT 1
- oca-gen-addon-readme: stop emitting an XML declaration HOT 1
- Fail to run pre-commit on OCA project: ERROR No matching distribution found for setuptools_scm HOT 2
- Update wiki "Migration to version 16.0" with `fields_view_get` becomes `get_view` HOT 2
- Mention data-hotkey in the 15.0 migration guide
- delete
- WIKI for documentation HOT 6
- module 'github3' has no attribute 'authorize'
- copy_maintainers script fails syncing the big teams HOT 7
- [17.0][mig] partner_statement: Migration to 17.0 HOT 1
- pandoc-3.2-1-amd64.deb added by precommit hook HOT 5
- Update command in the migration section for wiki "Migration to version 17.0". HOT 2
- Migration to version 17.0 project/project_template
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maintainer-tools.