Giter Site home page Giter Site logo

Comments (3)

sbidoul avatar sbidoul commented on July 20, 2024

Does it make sense to use pylint-odoo for this project? I'd think flake8 is sufficient. Or you can disable messages in .pylintrc?

But overall I think the oca addons repo template does not apply to openupgrade, as it is meant to be used with... addons repos :)

from maintainer-tools.

legalsylvain avatar legalsylvain commented on July 20, 2024

But overall I think the oca addons repo template does not apply to openupgrade, as it is meant to be used with... addons repos :)

But that's now addons repo. See :

Does it make sense to use pylint-odoo for this project? I'd think flake8 is sufficient. Or you can disable messages in .pylintrc?

Some checks maybe doesn't make sense or will be useless, but framework module contains code that can be "pylinted" and migrations scripts contains python files that can be also checked. relative-import, sql-injection, ...
In fact, for the time being, I just disabled one check here :
https://github.com/OCA/OpenUpgrade/blob/16.0/.pylintrc#L72 because there are a lot of xml files. (noupdate_changes.xml) that are not imported in the manifest. (file-not-used)

Well, my question is why pylint think that a subfolder is a module.

(If not found, indeed I can disable missing-readme, but I think that something is wrong somewhere).

from maintainer-tools.

sbidoul avatar sbidoul commented on July 20, 2024

But that's now addons repo

Ah, ok, yes I remember that discussion.

Well, my question is why pylint think that a subfolder is a module.

That's probably a question for the pylint-odoo project then.

from maintainer-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.