Comments (3)
Does it make sense to use pylint-odoo for this project? I'd think flake8 is sufficient. Or you can disable messages in .pylintrc
?
But overall I think the oca addons repo template does not apply to openupgrade, as it is meant to be used with... addons repos :)
from maintainer-tools.
But overall I think the oca addons repo template does not apply to openupgrade, as it is meant to be used with... addons repos :)
But that's now addons repo. See :
- https://pypi.org/project/odoo-addon-openupgrade-framework/
- https://pypi.org/project/odoo-addon-openupgrade-scripts/
Does it make sense to use pylint-odoo for this project? I'd think flake8 is sufficient. Or you can disable messages in .pylintrc?
Some checks maybe doesn't make sense or will be useless, but framework module contains code that can be "pylinted" and migrations scripts contains python files that can be also checked. relative-import
, sql-injection
, ...
In fact, for the time being, I just disabled one check here :
https://github.com/OCA/OpenUpgrade/blob/16.0/.pylintrc#L72 because there are a lot of xml files. (noupdate_changes.xml) that are not imported in the manifest. (file-not-used
)
Well, my question is why pylint think that a subfolder is a module.
(If not found, indeed I can disable missing-readme
, but I think that something is wrong somewhere).
from maintainer-tools.
But that's now addons repo
Ah, ok, yes I remember that discussion.
Well, my question is why pylint think that a subfolder is a module.
That's probably a question for the pylint-odoo project then.
from maintainer-tools.
Related Issues (20)
- pre-commit crashes in CI HOT 1
- Documentation for the best way to manage a high number of OCA repositories HOT 11
- I faced with error while using this module in pre-commit. HOT 1
- About squashing translation commits HOT 2
- Update our tooling to support Odoo 17 HOT 20
- Mention `odoo-module-migrator` in migration procedure wiki page HOT 1
- Mention `oca-port` in migration procedure wiki page HOT 6
- oca-gen-addon-readme: exits with no error if `description.rst` is not present HOT 14
- Update migration v17 Wiki HOT 2
- Clarify CONTRIBUTOR.md formatting HOT 20
- Wiki migration 17.0: New Settings format HOT 1
- oca-gen-addon-readme: stop emitting an XML declaration HOT 1
- Fail to run pre-commit on OCA project: ERROR No matching distribution found for setuptools_scm HOT 2
- Update wiki "Migration to version 16.0" with `fields_view_get` becomes `get_view` HOT 2
- Mention data-hotkey in the 15.0 migration guide
- delete
- WIKI for documentation HOT 6
- module 'github3' has no attribute 'authorize'
- copy_maintainers script fails syncing the big teams HOT 7
- [17.0][mig] partner_statement: Migration to 17.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maintainer-tools.