Comments (12)
I like it. However, basically every line of JS code will violate that standard in OCA, so I don't think it's practical as of today. I don't feel like @elicoidal... 😏
ESLint also offers an additional benefit of being able to catch ES6+ code, which should be forbidden for all Odoo code as of today (see OCA/maintainer-tools#383). In v8-11 versions this saves a lot of hard debugging time with PhantomJS tests breaking the world.
I think that a simple note in the docs that directs to our current ESLint config, which is currently quite hidden, and tells the developer to just install eslint and apply that configuration to know if his code is OK would be better.
Let me ping @OCA/web-maintainers @OCA/website-maintainers @OCA/e-commerce-maintainers.
from odoo-community.org.
I would be in favor but looks like a big leap for the OCA.
To be said that we do not have that many lines in jscript in OCA.
from odoo-community.org.
I think that a simple note in the docs that directs to our current ESLint config, which is currently quite hidden, and tells the developer to just install eslint and apply that configuration to know if his code is OK would be better.
👍 and we may want to update the JS here https://github.com/OCA/maintainer-tools/tree/master/template/module/static/src/js and add a special README/reference on recommended ways to deal w/ JS.
from odoo-community.org.
I like it. However, basically every line of JS code will violate that standard in OCA, so I don't think it's practical as of today. I don't feel like @elicoidal
looks like we agree no? @yajo 👅
from odoo-community.org.
Information about the standards allowed in v13.0:~
Production Code: ES5 (2009 - IE11 Support). Can use modern Promise (ES6: Mostly adopted by browsers)- Test Code: ES8 (2017)
Since Odoo 13.0 ES6 is supported: https://www.odoo.com/documentation/13.0/administration/install/deploy.html#supported-browsers
from odoo-community.org.
from odoo-community.org.
@yajo Thanks for ESLint config link!
Surprised that Odoo 13 supports IE11 (https://html5test.com/compare/browser/ie-11/chrome-68/firefox-60/edge-18.html) :S but it's understandable (https://www.netmarketshare.com/browser-market-share.aspx)...
from odoo-community.org.
Odoo 13 is not going to support it officially AFAIK. Odoo 12 does.
from odoo-community.org.
looks like we agree no? @yajo tongue
Yes! I was telling about this part: "we do not have that many lines in jscript in OCA". I feel we have a lot of them! Only that! 😉
Odoo 13 is not going to support it officially AFAIK. Odoo 12 does.
Let me refresh your memory: 😋 OCA/maintainer-tools#383 (comment)
from odoo-community.org.
Let me refresh your memory
Ouch, that hurts! IE11 still...
OK, then it will be Odoo 14 when we will be able to standardize JS guidelines.
from odoo-community.org.
Hello guys, would like you to help me how to use datatable on odoo, please
from odoo-community.org.
where addond directory im my repo psae-droob-of-continent-1
from odoo-community.org.
Related Issues (20)
- Need Help
- Outdated shop HOT 3
- Contributing guidelines not rendered HOT 14
- File naming for views HOT 14
- Where put "Action" records? HOT 2
- About ID names... HOT 1
- Author vs Contributor HOT 4
- Members are not shown in the webpage HOT 5
- wrong faq link on OCAs-Projects page HOT 1
- Contribution guide mixes syntax HOT 3
- Possibility of translating the documentation
- Product Harmonized System Codes
- issue with odoo-community apps download after upgrade HOT 3
- Chat and forum channels not advertised HOT 1
- QUESTION: Is pep80 necessary today? HOT 2
- TypeError: $focusable is undefined
- Broken link in guidelines HOT 2
- Broken link to FAQ in Code page
- W7936 is triggered when a package name is different from the import HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from odoo-community.org.