Giter Site home page Giter Site logo

Comments (2)

gadmm avatar gadmm commented on June 8, 2024

For the context, the bigger picture is that there was a lot of resource unsafety in the runtime due to asynchronous exceptions being raised (and there still is, with PRs open to progress in fixing the situation). This function is part of an effort to 1) reduce the number of places where such exceptions can arise and 2) provide ways to properly deal with them (clean-up resources and re-raise). The rationalization of async exceptions in the runtime was started by Jacques-Henri for the purpose of memprof to avoid it remaining in an invalid state when exceptions arise during allocations, so it happened in parallel of the multicore development. So any reorganisation is normal (and typical of this effort) because the code has to be async-exception-safe.

This particular function was introduced for Coq but it was also used to fix bugs in the ocaml runtime (see e.g. runtime/gc_ctrl.c), so I wonder what happened to the calls to this function (and their associated commits) during the rebase on top of 4.12.

from ocaml-multicore.

gadmm avatar gadmm commented on June 8, 2024

This is now fixed in the PR mentioned above, the issue can be closed.

from ocaml-multicore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.