Giter Site home page Giter Site logo

Comments (7)

gasche avatar gasche commented on June 8, 2024

I can't make a better guess than you did, so I would just try bisecting typing/ changes between 5.1 and 5.2.

from ocaml.

kit-ty-kate avatar kit-ty-kate commented on June 8, 2024

@Octachron made some progress debugging this in the meantime and it seems to be related to the preview of ppxlib we are using. Either one of us will close this if it's confirmed to be ppxlib-only issue

from ocaml.

Octachron avatar Octachron commented on June 8, 2024

This seems indeed increasingly likely to be a ppxlib issue. Typically, my reproduction case at https://github.com/Octachron/bug-reproduction-archives/tree/main/ppxlib_and_include fails with the reported error whenever a ppxlib-based ppx is used (even for an identity ppx).

from ocaml.

kit-ty-kate avatar kit-ty-kate commented on June 8, 2024

mmh, that's weird though, your example doesn't use any ppxlib feature other than the driver.
Ast_mapper.default_mapper is a function from compiler-libs. Maybe something is missing from there in 5.2

from ocaml.

kit-ty-kate avatar kit-ty-kate commented on June 8, 2024

oh nevermind i read the ppx / manual_ppx directories the wrong way, sorry for the noise

from ocaml.

gasche avatar gasche commented on June 8, 2024

Random thought: could this be some fallout from however ppxlib adapted to the changes in #12119, #12191? This was done in 5.1, but it may be that ppxlib changed it after the 5.1 release and we are only testing the change opam-wide now.

from ocaml.

kit-ty-kate avatar kit-ty-kate commented on June 8, 2024

I've just tried the main branch of ppxlib and it works just fine there if that was what you were thinking.

However I also managed to reduce @Octachron's test case even more: Octachron/bug-reproduction-archives#1
and it turns out the issue is in the way private types are translated in ppxlib.

I'll close this issue to avoid further noise. The ppxlib maintainers have been notified.

from ocaml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.