Giter Site home page Giter Site logo

recovery option diseapperaed about parcels HOT 3 CLOSED

gmaze avatar gmaze commented on August 10, 2024
recovery option diseapperaed

from parcels.

Comments (3)

gmaze avatar gmaze commented on August 10, 2024

the peace of code that was used before was in the kenernalsoa.py execute method:

        if recovery is None:
            recovery = {}
        elif ErrorCode.ErrorOutOfBounds in recovery and ErrorCode.ErrorThroughSurface not in recovery:
            recovery[ErrorCode.ErrorThroughSurface] = recovery[ErrorCode.ErrorOutOfBounds]
        recovery_map = recovery_base_map.copy()
        recovery_map.update(recovery)

then later in the code here the recovery_map was used to customise particle behavior when specific errors was raise.

but this has been removed in v.3.0.0 in kernels.py

from parcels.

erikvansebille avatar erikvansebille commented on August 10, 2024

Thanks for reporting, @gmaze. The recovery codes were indeed deprecated in v3.0.0, because their implementation was extremely inefficient/slow and there were no cases where what they did could not be done by 'normal' kernels in the new way that we implemented the Kernel loop.

All of this has been listed in the release notes of v3.0.0 and specifically in the Working with Status Codes section of the new Kernel Loop tutorial.

Could I encourage you to try implementing your recovery with normal Kernels? It will likely also speed up your code.

Let me know if you need specific help. Since Parcels is actively-developed research software, it can at times still be rough around the edges. But the only way to improve it is to help each other :-)

from parcels.

gmaze avatar gmaze commented on August 10, 2024

ok, great @erikvansebille and thank you for the explanation and for pointing out the new Status Codes

we will try to update our software to work with the new version, and hopefully this could also improve performances !
and we'll surely raise issues if we can't work this out without more help, thanks 🤝

from parcels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.