Giter Site home page Giter Site logo

numpy random randint about parcels HOT 5 CLOSED

lucvandenbulcke avatar lucvandenbulcke commented on September 14, 2024
numpy random randint

from parcels.

Comments (5)

lucvandenbulcke avatar lucvandenbulcke commented on September 14, 2024 1

I checked as well (before seeing your latest answer), and confirm it's the only place.
I can try and create a branch and the PR.

from parcels.

erikvansebille avatar erikvansebille commented on September 14, 2024

Thanks for bringing this up @lucvandenbulcke, this could be another issue with the new NumPy 2.0.0 release? Just like #1589 which we patched in v3.0.4.

Would you want to create a PR with this change from np.randint(...) to np.random.randint(...)? And perhaps check if there are other instances of this old use too? Or would you prefer if I create this PR?

from parcels.

erikvansebille avatar erikvansebille commented on September 14, 2024

And perhaps check if there are other instances of this old use too?

Actually I juist checked, and this seems to be the only place in the parcels code where a numpy-random function is not called as np.random.funcname(), so only this change needs to be done

from parcels.

lucvandenbulcke avatar lucvandenbulcke commented on September 14, 2024

I think that I can't create a branch :
luc@thinkpad:/data/oceans/parcels$ git clone [email protected]:OceanParcels/parcels.git
...
luc@thinkpad:/data/oceans/parcels$ cd parcels/
luc@thinkpad:/data/oceans/parcels/parcels$ git checkout -b lucvandenbulcke-numpy-bug
Switched to a new branch 'lucvandenbulcke-numpy-bug'
luc@thinkpad:/data/oceans/parcels/parcels$ git push origin lucvandenbulcke-numpy-bug
ERROR: Permission to OceanParcels/parcels.git denied to lucvandenbulcke.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.

I don't know how else I should create a pull request -- I guess it's not worth to create a fork just for this.
Apart from this, I made scripts using parcels, that I could share on github if it's useful for anybody (but I don't know where exactly).

from parcels.

VeckoTheGecko avatar VeckoTheGecko commented on September 14, 2024

Hi @lucvandenbulcke. This bug has now been patched in #1604. If you'd like to use these changes, please follow the development installation instructions outlined in the "Installation for developers" section of our documentation.

These changes will be available through conda in the next release.

from parcels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.