Comments (5)
I checked as well (before seeing your latest answer), and confirm it's the only place.
I can try and create a branch and the PR.
from parcels.
Thanks for bringing this up @lucvandenbulcke, this could be another issue with the new NumPy 2.0.0 release? Just like #1589 which we patched in v3.0.4.
Would you want to create a PR with this change from np.randint(...)
to np.random.randint(...)
? And perhaps check if there are other instances of this old use too? Or would you prefer if I create this PR?
from parcels.
And perhaps check if there are other instances of this old use too?
Actually I juist checked, and this seems to be the only place in the parcels code where a numpy-random function is not called as np.random.funcname()
, so only this change needs to be done
from parcels.
I think that I can't create a branch :
luc@thinkpad:/data/oceans/parcels$ git clone [email protected]:OceanParcels/parcels.git
...
luc@thinkpad:/data/oceans/parcels$ cd parcels/
luc@thinkpad:/data/oceans/parcels/parcels$ git checkout -b lucvandenbulcke-numpy-bug
Switched to a new branch 'lucvandenbulcke-numpy-bug'
luc@thinkpad:/data/oceans/parcels/parcels$ git push origin lucvandenbulcke-numpy-bug
ERROR: Permission to OceanParcels/parcels.git denied to lucvandenbulcke.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.
I don't know how else I should create a pull request -- I guess it's not worth to create a fork just for this.
Apart from this, I made scripts using parcels, that I could share on github if it's useful for anybody (but I don't know where exactly).
from parcels.
Hi @lucvandenbulcke. This bug has now been patched in #1604. If you'd like to use these changes, please follow the development installation instructions outlined in the "Installation for developers" section of our documentation.
These changes will be available through conda in the next release.
from parcels.
Related Issues (20)
- Refactoring of FieldSet field store HOT 2
- tutorial_diffusion: SmagDiff example not working HOT 3
- Binder tag broken? HOT 3
- Consider using KMeans from scipy instead of sklearn HOT 2
- (Windows only) "access violation" when running simulations with custom kernels HOT 1
- Parcels versioning and deprecation policy HOT 3
- Test suite improvements
- "only length-1 arrays can be converted to Python scalars" error when setting periodic boundaries HOT 5
- Read only values in `Field` HOT 2
- Maintainer documentation HOT 2
- Sampling and storing `particle.xi` as a variable gives a different result to calling `particle.xi` (in JIT mode) HOT 2
- Unreliable `Field.fieldtype` constant HOT 2
- Warnings vs ValueErrors with user provided params HOT 2
- Improve `print` for key Parcels classes HOT 3
- Warning when particles are initialised outside time domain
- Parcels API review
- Warning for misaligned timestepping and outputdt HOT 1
- Remove GridSet class from Public API HOT 1
- Adding information on how to define dimensions for tracers on C-grid
- DOC: Viewing and editing metadata dict HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parcels.