Giter Site home page Giter Site logo

Comments (2)

pviti avatar pviti commented on June 7, 2024

To isolate the problem I've also tried to generate a new clean CLI with just a simple test command and a prerun hook, but still any Error inside the hook is ignored and the command is normally run without messages on the console

from core.

mdonnalley avatar mdonnalley commented on June 7, 2024

@pviti Sorry for the delayed response.

We made the conscious decision to no longer allow hooks to exit the process so that hooks could be used to gather information across plugins. For example, I could have my-cli list things command that runs a hook to gather the things to list from all the installed plugins. In that scenario I wouldn't want one failed hook to exit the entire process.

That being said, the runHook method now returns the successes and failures from the hook execution. So it is still possible to exit the process based on the result of the hook execution

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.