Comments (16)
Thanks for the context - I was able to reproduce it with the following:
npm install -g twilio-cli
twilio plugins:install @twilio-labs/plugin-flex
twilio flex:plugins:create twilio-test
cd twilio-test
twilio flex:plugins:start
I'll report back once I know more about what's causing this
from core.
I'll get in touch with the respective team internally at Twilio. Thanks @mdonnalley !
from core.
Yeah also facing the same issue. Build pipeline was successful in building using twilio-cli 3.4.1 yesterday. Tried the same build again today and got this error. Tried upgrading both flex-plugin and twilio-cli versions, but no success. Seems something has broken upstream, perhaps.
from core.
I am reproducing it on Ubuntu via Github Actions.
from core.
@endreymarcell-wise @shrutiburman happy to help. I'm going to close this issue for now but feel free to reopen it if you feel it's necessary
from core.
Facing the same issue with Node 14 on aws codebuild containers. I tried it with twilio-cli version 5.0 as well and still it gives the same issue.
from core.
Same issue here with twilio-cli 5.1.0
from core.
@endreymarcell-wise I'm unable to reproduce this with a freshly generated oclif cli and the latest oclif/core
So I'm assuming that there's something unique about your code base that's causing this. Can you provide any additional details that might help me reproduce it? Thanks!
from core.
@bmcgrogan here's the dependency on oclif:
https://github.com/twilio/twilio-cli-core/blob/e8f132bd2b02717f28545337db91b582ca18575d/package.json#L45
As you can see, @twilio/cli-core depends on @oclif/core and since it's using ^ as the specifier, it'll get new minor versions as they roll out. So rolling back twilio-cli itself can not help.
FWIW my current workaround is to just remove the offending line from this one file on github:
echo 'Removing a breaking line from this dependency until https://github.com/oclif/core/issues/528 is fixed'
mv ~/.twilio-cli/node_modules/\@oclif/core/lib/command.js /tmp/command.js.bak
grep -v 'this.warnIfFlagDeprecated' /tmp/command.js.bak > ~/.twilio-cli/node_modules/\@oclif/core/lib/command.js
from core.
Hey @mdonnalley, thanks for picking this up! I'm not sure what would be special about my codebase, and as you can see, others are also reporting the same issue.
Nevertheless, I'm happy to provide more details as much as I can (codebase is my company's, not mine).
from core.
@mdonnalley, this might help: the issue somehow is prominent in Windows machines and Mac Silicon chips. I somehow couldn't reporduce it in my darwin os.
from core.
@endreymarcell-wise thanks - any additional details would be greatly appreciated
I just tried the following:
git clone https://github.com/twilio/twilio-cli
npm install
bin/dev config list
And didn't see the issue. Is there a particular command of yours that this is happening on?
I also verified that the 1.19.0 is being used throughout the dependency tree:
~/repos/twilio/twilio-cli (main) ยป jq .version node_modules/@oclif/core/package.json
"1.19.0"
from core.
The exact command I am running is twilio flex:plugins:deploy
. The background for this is that we are a customer of Twilio, we are using their product called Flex, and have a custom plugin for that which we deploy using Twilio's CLI. Not sure how you should be able to reproduce this setup without going through a whole lot of hassle. For what it's worth, the steps are described here: https://www.twilio.com/docs/flex/quickstart/getting-started-plugin
from core.
@endreymarcell-wise The issue is that you're passing the parse
method in here without binding this
to it
Changing super.parse
to super.parse.bind(this)
should resolve the issue.
Not binding this
worked for you up to this point because parse
didn't access any class properties or methods until the change introduced in 1.19.0
from core.
Thanks for pinpointing the issue!
If you think the linked code is misusing the method, I'm happy to open an issue towards twilio, seeing that it's their code, not mine :)
from core.
Folks following this thread, plugin-flex has released a patch with the fix, v6.0.2, that should solve this problem.
from core.
Related Issues (20)
- Errors with 1.16.4 and typescript 4.8.3 HOT 1
- Deno Support for Packaging HOT 5
- if a command has a flag with `multiple:true` it will not error out on a non-existent flag (the non-existent flag ends up as the arg) HOT 3
- Hooks are not working properly HOT 4
- Can you release new version of @oclif/core to npm? HOT 1
- help for a command: description section adds an extra newline per line HOT 1
- Unnecessary warnings when command flags are marked as deprecated
- Adding `strict=false` parses a non-existing flag as a `arg`
- Issues when running script from Usage in readme HOT 2
- Import packge.json (using esm) HOT 1
- Adding plugins from GitHub/Gitlab repositories HOT 2
- topics with no same-name command give odd help info HOT 2
- when does not support flags with false values
- [observed in v2] cli exits with code 0 even when the command is incorrect HOT 2
- `./bin/dev` loads from /src/commands ONLY if `/dist` does not exist HOT 3
- Receive `UnexpectedArgsError` when wrapping args/flags HOT 1
- `deprecated` property does not work when `=` is used to provide value HOT 4
- Return result in Main.ts run function HOT 2
- Cannot use arguments starting with '-' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.