Command.parse() method returns undefined flags

[CalemRoelofsSB]

Command.parse() method returns undefined flags

[CalemRoelofsSB]

Hey @WillieRuemmele, appreciate the rapid response (and @mshanemc for already have a PR open)!

did this change cause your commands to break, or was it just a difference?

This mainly is an issue for commands that perform different actions based on the presence or omission of certain combinations of flags (or a lack of flags completely).
Just as an example, if you have a command like mycli file that can do different operations based on flags like --delete or --update, it would be standard to have some sort of check like

if (!Object.keys(flags).length) {
 throw new CLIError('Must specify at least one flag!')
}

With this new behavior, that check would no longer work as flags would now equal { delete: undefined, update: undefined } which would be a breaking change.

We only caught it because of failing tests on a dependabot PR for bumping to 2.9.0

[WillieRuemmele]

Hi @CalemRoelofsSB - thanks for reporting this and creating a simple reproduction 🏆

this must've been introduced with #726

did this change cause your commands to break, or was it just a difference?