Giter Site home page Giter Site logo

move ts-node to devDependencies about core HOT 8 CLOSED

vorant94 avatar vorant94 commented on August 24, 2024 2
move ts-node to devDependencies

from core.

Comments (8)

cristiand391 avatar cristiand391 commented on August 24, 2024 2

hey, sorry missed the last response.

AFAIK, npm installs peerDependencies by default unless you do npm i --omit peer:
npm v7 announcement

Maybe we could remove ts-node from @oclif/core as dep and require plugins to have it as a devDep (which already do for bin/dev to work), but that would be a breaking change and might require some refactor to lazy-load ts-node code in core.

from core.

cristiand391 avatar cristiand391 commented on August 24, 2024

Hi @vorant94

ts-node is also used to compile TS plugins at runtime when they are linked, see:
#650

plugin/command loading is done in @oclif/core so it needs ts-node as a dep.

from core.

vorant94 avatar vorant94 commented on August 24, 2024

Hi @vorant94

ts-node is also used to compile TS plugins at runtime when they are linked, see:

#650

plugin/command loading is done in @oclif/core so it needs ts-node as a dep.

Is it acceptable to maybe make it a deepDep then?

from core.

cristiand391 avatar cristiand391 commented on August 24, 2024

Is it acceptable to maybe make it a deepDep then?

You mean making ts-node a peerDependency?

from core.

vorant94 avatar vorant94 commented on August 24, 2024

Is it acceptable to maybe make it a deepDep then?

You mean making ts-node a peerDependency?

yeah, sorry for typo

from core.

SuperchupuDev avatar SuperchupuDev commented on August 24, 2024

any updates on this issue? it's a bit annoying to have ts-node always installed when it doesn't get used by any of my dependencies

from core.

git2gus avatar git2gus commented on August 24, 2024

This issue has been linked to a new work item: W-14179298

from core.

mdonnalley avatar mdonnalley commented on August 24, 2024

Closed by #794

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.