Cannot read property 'split' of undefined

[frangio]

Cannot read property 'split' of undefined

[frangio]

Okay, it seems I'm getting the following response from GitHub:

  data:
   { error: 'redirect_uri_mismatch',
     error_description:
      'The redirect_uri MUST match the registered callback URL for this application.',

I had passed a random redirectUrl. Perhaps this function should check for errors in the response, though?

[gr2m]

Agree, it should! I'm currently working on other parts of Octokit but happy to review a pull request if you would like to give it a go.

[frangio]

I've been looking at this a bit and to me it seems like a there is a bug in @octokit/request. It should be rejecting the promise but it isn't.

Perhaps the status code in this situation is not being taken as an error. I'll reproduce to see what status it is.

[gr2m]

Ah I remember there was sth super odd about the POST https://github.com/login/oauth/access_token endpoint, the status code is not set correctly in case of an error. I'm sure I fixed this before ... but might got lost or it's in another repo. The POST https://github.com/login/oauth/access_token endpoint is such a pita :/

Can you start a PR with a failing test and we take it from there?

[frangio]

Sure! I've opened octokit/request.js#94.

[octokitbot]

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀