Giter Site home page Giter Site logo

Comments (5)

gr2m avatar gr2m commented on September 22, 2024

Make sure to add the keys in response schema overrides in workarounds.js

from routes.

RomanHotsiy avatar RomanHotsiy commented on September 22, 2024

@gr2m what about some keys that were generated from null?

e.g. here https://developer.github.com/v3/repos/#response template_repository is null in examples so I don't think it should be marked as required.

Btw, template_repository in this particular case is turned into type: string property which I suppose is another issue.

from routes.

gr2m avatar gr2m commented on September 22, 2024

right now, none of the keys are marked as required, which is not ideal either.

e.g. here https://developer.github.com/v3/repos/#response template_repository is null in examples so I don't think it should be marked as required.

I don't see the template_repository in the response?

from routes.

RomanHotsiy avatar RomanHotsiy commented on September 22, 2024

image

from routes.

gr2m avatar gr2m commented on September 22, 2024

I see it now. Sorry, odd that I missed it before.

Anyway, there is no ideal solution to this right now. We can add more workarounds to /lib/endpoint/overrides/workarounds.js on a case-to-case basis. But I think setting everything to required is still the better default.

Btw, template_repository in this particular case is turned into type: string property which I suppose is another issue

yeah, that seems unrelated

from routes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.