Comments (5)
Make sure to add the keys in response schema overrides in workarounds.js
from routes.
@gr2m what about some keys that were generated from null
?
e.g. here https://developer.github.com/v3/repos/#response template_repository
is null in examples so I don't think it should be marked as required.
Btw, template_repository
in this particular case is turned into type: string
property which I suppose is another issue.
from routes.
right now, none of the keys are marked as required, which is not ideal either.
e.g. here https://developer.github.com/v3/repos/#response template_repository is null in examples so I don't think it should be marked as required.
I don't see the template_repository
in the response?
from routes.
from routes.
I see it now. Sorry, odd that I missed it before.
Anyway, there is no ideal solution to this right now. We can add more workarounds to /lib/endpoint/overrides/workarounds.js
on a case-to-case basis. But I think setting everything to required is still the better default.
Btw, template_repository in this particular case is turned into type: string property which I suppose is another issue
yeah, that seems unrelated
from routes.
Related Issues (20)
- "reviewed" event is not documented for timeline HOT 1
- Issue body can be null HOT 1
- `PATCH /orgs/:org` is not deprecated HOT 2
- The automated release is failing 🚨 HOT 4
- OpenAPI info.description field has placeholder text HOT 2
- define the response payload for the emoji endpoint HOT 1
- define the response payloads for the markdown endpoints
- Invalid enum values for list workflow runs HOT 7
- List workflow runs: parameter type of "workflow_id" should be "string" HOT 1
- Refactor: we no longer need to keep track of multiple routes per endpoint section
- remove descriptions for URL parameters HOT 1
- Pagination: do not add `?{page,per_page} parameters for list endpoints only supporting `?since`
- Parse response headers from examples HOT 1
- An in-range update of now is breaking the build 🚨
- Incorrect files property in POST /gists HOT 3
- All null values are scrapped as type: string
- Add format for date-time strings
- The automated release is failing 🚨
- `"repository_selection"` response key is not a string, but an emum with the possible values: `"all"` or `"selected"`" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from routes.