Comments (3)
Looks like this will also be a problem in multilingual, e.g. https://github.com/octopress/multilingual/blob/master/lib/octopress-multilingual.rb#L130
https://github.com/octopress/multilingual/blob/master/lib/octopress-multilingual.rb#L152
Loads of array-ish operations on posts
in that file.
Issue on Multilingual - possibly related: octopress/multilingual#29
from ink.
Looking at the code I'm not super confident making a change without some support:
- I'm not sure how to run the tests - a note in the readme on that would be great.
- There are lines like
Octopress.site.pages << page
- are they fine, or do they need to use.docs
as well? - This would be a breaking change, so how should this be handled? Perhaps making a version 1.2.2 which is locked to jekyll
< 3
, and then a version 2.0 for jekyll>= 3.0.0
?
from ink.
Oops - looks like there's already a PR for this: #66
from ink.
Related Issues (20)
- Copy creates doubled full paths under octopress home folder HOT 1
- Support multilingual plugin configurations
- Can't get path of layout from plugin HOT 3
- Fonts copied to _site/plugin-slug/fonts/ HOT 1
- Pagination with theme gem HOT 4
- Add new template asset type (for generating pages)
- Missing Dependency - pry-byebug HOT 2
- Make it possible for plugin developers to --watch plugin assets
- Plugin not registering; registered plugin not enabled HOT 2
- List of thirdparty octopress 3 plugins? HOT 5
- Sass debug mode and sourcemap creation
- Ink asset cache is not cleared properly when Jekyll is watching for builds
- figure out how one plugin (theme) can override another plugin's css
- Ink pulling in backup .scss~ files HOT 1
- undefined method `[]' for nil:NilClass HOT 7
- Octopress ink crashes HOT 3
- Define order in the javascript files HOT 4
- Add LESS support for plugin assets
- Jekyll 3 changed site.posts from an Array to a Collection which causes deprecation warning in Ink HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ink.